From 022707e65abe47644f0aa27d69bd3d641ddfdc1b Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Tue, 20 Jan 2015 01:03:09 +0000 Subject: [PATCH] Bitcode: Simplify MDNode subclass dispatch, NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@226535 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Bitcode/Writer/BitcodeWriter.cpp | 31 +++++++++++++++++++--------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/lib/Bitcode/Writer/BitcodeWriter.cpp b/lib/Bitcode/Writer/BitcodeWriter.cpp index 43af7aed99d..567e935cfa3 100644 --- a/lib/Bitcode/Writer/BitcodeWriter.cpp +++ b/lib/Bitcode/Writer/BitcodeWriter.cpp @@ -764,7 +764,7 @@ static void WriteValueAsMetadata(const ValueAsMetadata *MD, static void WriteMDTuple(const MDTuple *N, const ValueEnumerator &VE, BitstreamWriter &Stream, - SmallVectorImpl &Record) { + SmallVectorImpl &Record, unsigned Abbrev) { for (unsigned i = 0, e = N->getNumOperands(); i != e; ++i) { Metadata *MD = N->getOperand(i); assert(!(MD && isa(MD)) && @@ -773,7 +773,7 @@ static void WriteMDTuple(const MDTuple *N, const ValueEnumerator &VE, } Stream.EmitRecord(N->isDistinct() ? bitc::METADATA_DISTINCT_NODE : bitc::METADATA_NODE, - Record); + Record, Abbrev); Record.clear(); } @@ -791,6 +791,12 @@ static void WriteMDLocation(const MDLocation *N, const ValueEnumerator &VE, Record.clear(); } +static void WriteGenericDwarfNode(const GenericDwarfNode *, + const ValueEnumerator &, BitstreamWriter &, + SmallVectorImpl &, unsigned) { + llvm_unreachable("unimplemented"); +} + static void WriteModuleMetadata(const Module *M, const ValueEnumerator &VE, BitstreamWriter &Stream) { @@ -810,7 +816,7 @@ static void WriteModuleMetadata(const Module *M, MDSAbbrev = Stream.EmitAbbrev(Abbv); } - unsigned LocAbbrev = 0; + unsigned MDLocationAbbrev = 0; if (VE.hasMDLocation()) { // Abbrev for METADATA_LOCATION. // @@ -823,7 +829,7 @@ static void WriteModuleMetadata(const Module *M, Abbv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 8)); Abbv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 6)); Abbv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 6)); - LocAbbrev = Stream.EmitAbbrev(Abbv); + MDLocationAbbrev = Stream.EmitAbbrev(Abbv); } unsigned NameAbbrev = 0; @@ -836,15 +842,20 @@ static void WriteModuleMetadata(const Module *M, NameAbbrev = Stream.EmitAbbrev(Abbv); } + unsigned MDTupleAbbrev = 0; + unsigned GenericDwarfNodeAbbrev = 0; SmallVector Record; for (const Metadata *MD : MDs) { - if (const MDLocation *Loc = dyn_cast(MD)) { - WriteMDLocation(Loc, VE, Stream, Record, LocAbbrev); - continue; - } if (const MDNode *N = dyn_cast(MD)) { - WriteMDTuple(cast(N), VE, Stream, Record); - continue; + switch (N->getMetadataID()) { + default: + llvm_unreachable("Invalid MDNode subclass"); +#define HANDLE_MDNODE_LEAF(CLASS) \ + case Metadata::CLASS##Kind: \ + Write##CLASS(cast(N), VE, Stream, Record, CLASS##Abbrev); \ + continue; +#include "llvm/IR/Metadata.def" + } } if (const auto *MDC = dyn_cast(MD)) { WriteValueAsMetadata(MDC, VE, Stream, Record); -- 2.34.1