From 031fbaeb296558e343ddc302d169f2b2673f58f5 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Sun, 22 Mar 2015 15:58:21 +0000 Subject: [PATCH] Prevent CHECK-NOTs from matching file paths A build directory with a name like `build-Werror` would hit a false positive on these `CHECK-NOT`s before, since the actual error line looks like: .../build-Werror/bin/llvm-as :1:2: error: ... Switch to using: CHECK-NOT: error: (note the trailing semi-colon) to avoid matching almost any file path. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@232917 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/Assembler/invalid-generic-debug-node-tag-overflow.ll | 2 +- test/Assembler/invalid-mdcompileunit-language-overflow.ll | 2 +- test/Assembler/invalid-mdexpression-large.ll | 2 +- test/Assembler/invalid-mdlocation-overflow-column.ll | 2 +- test/Assembler/invalid-mdlocation-overflow-line.ll | 2 +- test/Assembler/invalid-mdsubrange-count-large.ll | 2 +- test/Assembler/invalid-mdsubrange-count-negative.ll | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/test/Assembler/invalid-generic-debug-node-tag-overflow.ll b/test/Assembler/invalid-generic-debug-node-tag-overflow.ll index 1722caa0a73..b5189469f07 100644 --- a/test/Assembler/invalid-generic-debug-node-tag-overflow.ll +++ b/test/Assembler/invalid-generic-debug-node-tag-overflow.ll @@ -1,6 +1,6 @@ ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s -; CHECK-NOT: error +; CHECK-NOT: error: !0 = !GenericDebugNode(tag: 65535) ; CHECK: :[[@LINE+1]]:29: error: value for 'tag' too large, limit is 65535 diff --git a/test/Assembler/invalid-mdcompileunit-language-overflow.ll b/test/Assembler/invalid-mdcompileunit-language-overflow.ll index 14dab17868f..1849867edae 100644 --- a/test/Assembler/invalid-mdcompileunit-language-overflow.ll +++ b/test/Assembler/invalid-mdcompileunit-language-overflow.ll @@ -1,6 +1,6 @@ ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s -; CHECK-NOT: error +; CHECK-NOT: error: !0 = !MDCompileUnit(language: 65535, file: !MDFile(filename: "a", directory: "b")) diff --git a/test/Assembler/invalid-mdexpression-large.ll b/test/Assembler/invalid-mdexpression-large.ll index 43b8ce0c9ef..fb304137ed7 100644 --- a/test/Assembler/invalid-mdexpression-large.ll +++ b/test/Assembler/invalid-mdexpression-large.ll @@ -1,6 +1,6 @@ ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s -; CHECK-NOT: error +; CHECK-NOT: error: !0 = !MDExpression(18446744073709551615) ; CHECK: :[[@LINE+1]]:20: error: element too large, limit is 18446744073709551615 diff --git a/test/Assembler/invalid-mdlocation-overflow-column.ll b/test/Assembler/invalid-mdlocation-overflow-column.ll index 92ea661ed34..1c06697d01e 100644 --- a/test/Assembler/invalid-mdlocation-overflow-column.ll +++ b/test/Assembler/invalid-mdlocation-overflow-column.ll @@ -2,7 +2,7 @@ !0 = !{} -; CHECK-NOT: error +; CHECK-NOT: error: !1 = !MDLocation(column: 65535, scope: !0) ; CHECK: :[[@LINE+1]]:26: error: value for 'column' too large, limit is 65535 diff --git a/test/Assembler/invalid-mdlocation-overflow-line.ll b/test/Assembler/invalid-mdlocation-overflow-line.ll index 535b4c9a5c9..571a555daef 100644 --- a/test/Assembler/invalid-mdlocation-overflow-line.ll +++ b/test/Assembler/invalid-mdlocation-overflow-line.ll @@ -2,7 +2,7 @@ !0 = !{} -; CHECK-NOT: error +; CHECK-NOT: error: !1 = !MDLocation(line: 4294967295, scope: !0) ; CHECK: :[[@LINE+1]]:24: error: value for 'line' too large, limit is 4294967295 diff --git a/test/Assembler/invalid-mdsubrange-count-large.ll b/test/Assembler/invalid-mdsubrange-count-large.ll index 0d150aa9834..733c4afa34a 100644 --- a/test/Assembler/invalid-mdsubrange-count-large.ll +++ b/test/Assembler/invalid-mdsubrange-count-large.ll @@ -1,6 +1,6 @@ ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s -; CHECK-NOT: error +; CHECK-NOT: error: !0 = !MDSubrange(count: 9223372036854775807) ; CHECK: :[[@LINE+1]]:25: error: value for 'count' too large, limit is 9223372036854775807 diff --git a/test/Assembler/invalid-mdsubrange-count-negative.ll b/test/Assembler/invalid-mdsubrange-count-negative.ll index 92c0b4e7ca4..9bfe784ab5d 100644 --- a/test/Assembler/invalid-mdsubrange-count-negative.ll +++ b/test/Assembler/invalid-mdsubrange-count-negative.ll @@ -1,6 +1,6 @@ ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s -; CHECK-NOT: error +; CHECK-NOT: error: !0 = !MDSubrange(count: -1) ; CHECK: :[[@LINE+1]]:25: error: value for 'count' too small, limit is -1 -- 2.34.1