From 0623e90398153be61226ad19f1b40d3817874526 Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Wed, 24 Mar 2010 23:35:21 +0000 Subject: [PATCH] Temporarily revert this, it's causing an issue with an internal project. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@99451 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Instructions.h | 14 -------------- include/llvm/Support/CallSite.h | 4 ---- lib/Transforms/Utils/InlineFunction.cpp | 4 +--- lib/VMCore/Instructions.cpp | 15 ++------------- test/Transforms/Inline/noinline.ll | 18 ------------------ 5 files changed, 3 insertions(+), 52 deletions(-) delete mode 100644 test/Transforms/Inline/noinline.ll diff --git a/include/llvm/Instructions.h b/include/llvm/Instructions.h index 413a595ab38..2fe1abba135 100644 --- a/include/llvm/Instructions.h +++ b/include/llvm/Instructions.h @@ -971,13 +971,6 @@ public: unsigned getParamAlignment(unsigned i) const { return AttributeList.getParamAlignment(i); } - - /// @brief Return true if the call should not be inlined. - bool isNoInline() const { return paramHasAttr(~0, Attribute::NoInline); } - void setIsNoInline(bool Value) { - if (Value) addAttribute(~0, Attribute::NoInline); - else removeAttribute(~0, Attribute::NoInline); - } /// @brief Determine if the call does not access memory. bool doesNotAccessMemory() const { @@ -2463,13 +2456,6 @@ public: return AttributeList.getParamAlignment(i); } - /// @brief Return true if the call should not be inlined. - bool isNoInline() const { return paramHasAttr(~0, Attribute::NoInline); } - void setIsNoInline(bool Value) { - if (Value) addAttribute(~0, Attribute::NoInline); - else removeAttribute(~0, Attribute::NoInline); - } - /// @brief Determine if the call does not access memory. bool doesNotAccessMemory() const { return paramHasAttr(~0, Attribute::ReadNone); diff --git a/include/llvm/Support/CallSite.h b/include/llvm/Support/CallSite.h index 9d9a30e6ad2..4c6689fffd0 100644 --- a/include/llvm/Support/CallSite.h +++ b/include/llvm/Support/CallSite.h @@ -76,10 +76,6 @@ public: /// @brief Extract the alignment for a call or parameter (0=unknown). uint16_t getParamAlignment(uint16_t i) const; - /// @brief Return true if the call should not be inlined. - bool isNoInline() const; - void setIsNoInline(bool Value = true); - /// @brief Determine if the call does not access memory. bool doesNotAccessMemory() const; void setDoesNotAccessMemory(bool doesNotAccessMemory = true); diff --git a/lib/Transforms/Utils/InlineFunction.cpp b/lib/Transforms/Utils/InlineFunction.cpp index 599fe33aa03..17f8827fd5c 100644 --- a/lib/Transforms/Utils/InlineFunction.cpp +++ b/lib/Transforms/Utils/InlineFunction.cpp @@ -229,9 +229,7 @@ bool llvm::InlineFunction(CallSite CS, CallGraph *CG, const TargetData *TD, const Function *CalledFunc = CS.getCalledFunction(); if (CalledFunc == 0 || // Can't inline external function or indirect CalledFunc->isDeclaration() || // call, or call to a vararg function! - CalledFunc->getFunctionType()->isVarArg() || - CS.isNoInline()) // Call site is marked noinline. - return false; + CalledFunc->getFunctionType()->isVarArg()) return false; // If the call to the callee is not a tail call, we must clear the 'tail' diff --git a/lib/VMCore/Instructions.cpp b/lib/VMCore/Instructions.cpp index 11e218c49ec..171e0211ddb 100644 --- a/lib/VMCore/Instructions.cpp +++ b/lib/VMCore/Instructions.cpp @@ -31,13 +31,13 @@ using namespace llvm; //===----------------------------------------------------------------------===// #define CALLSITE_DELEGATE_GETTER(METHOD) \ - Instruction *II = getInstruction(); \ + Instruction *II(getInstruction()); \ return isCall() \ ? cast(II)->METHOD \ : cast(II)->METHOD #define CALLSITE_DELEGATE_SETTER(METHOD) \ - Instruction *II = getInstruction(); \ + Instruction *II(getInstruction()); \ if (isCall()) \ cast(II)->METHOD; \ else \ @@ -66,17 +66,6 @@ bool CallSite::paramHasAttr(uint16_t i, Attributes attr) const { uint16_t CallSite::getParamAlignment(uint16_t i) const { CALLSITE_DELEGATE_GETTER(getParamAlignment(i)); } - -/// @brief Return true if the call should not be inlined. -bool CallSite::isNoInline() const { - CALLSITE_DELEGATE_GETTER(isNoInline()); -} - -void CallSite::setIsNoInline(bool Value) { - CALLSITE_DELEGATE_GETTER(setIsNoInline(Value)); -} - - bool CallSite::doesNotAccessMemory() const { CALLSITE_DELEGATE_GETTER(doesNotAccessMemory()); } diff --git a/test/Transforms/Inline/noinline.ll b/test/Transforms/Inline/noinline.ll deleted file mode 100644 index dc3f6e00309..00000000000 --- a/test/Transforms/Inline/noinline.ll +++ /dev/null @@ -1,18 +0,0 @@ -; RUN: opt %s -inline -S | FileCheck %s -; PR6682 -declare void @foo() nounwind - -define void @bar() nounwind { -entry: - tail call void @foo() nounwind - ret void -} - -define void @bazz() nounwind { -entry: - tail call void @bar() nounwind noinline - ret void -} - -; CHECK: define void @bazz() -; CHECK: call void @bar() -- 2.34.1