From 0660730467aed8d55da69d5f1ec9c8a577ec4757 Mon Sep 17 00:00:00 2001 From: Mark McDuff Date: Wed, 1 Apr 2015 15:17:20 -0700 Subject: [PATCH] improve split() docs Summary: From reading the docs, I assumed that casting exceptions would be caught. Let's clarify this. Test Plan: readingiskey Reviewed By: yfeldblum@fb.com Subscribers: folly-diffs@, yfeldblum, chalfant FB internal diff: D1960186 Signature: t1:1960186:1427920471:b7aa2af38a90a986418b98294fc0f69e678f0d1e --- folly/String.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/folly/String.h b/folly/String.h index 7da981e8..167a6b5c 100644 --- a/folly/String.h +++ b/folly/String.h @@ -436,7 +436,9 @@ void splitTo(const Delim& delimiter, * Split a string into a fixed number of string pieces and/or numeric types * by delimiter. Any numeric type that folly::to<> can convert to from a * string piece is supported as a target. Returns 'true' if the fields were - * all successfully populated. + * all successfully populated. Returns 'false' if there were too few fields + * in the input, or too many fields if exact=true. Casting exceptions will + * not be caught. * * Examples: * -- 2.34.1