From 07466510a7738e3ffdaa99689ce9c7ede33f086d Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Sun, 3 Jan 2016 08:57:41 +0000 Subject: [PATCH] [TableGen] Simplify some code slightly. No need to check if the arrays are empty before printing. The loop can be made to print the same thing if the loop is empty. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@256703 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/TableGen/SubtargetEmitter.cpp | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/utils/TableGen/SubtargetEmitter.cpp b/utils/TableGen/SubtargetEmitter.cpp index 6246d811123..d056de003e1 100644 --- a/utils/TableGen/SubtargetEmitter.cpp +++ b/utils/TableGen/SubtargetEmitter.cpp @@ -185,16 +185,12 @@ unsigned SubtargetEmitter::FeatureKeyValues(raw_ostream &OS) { const std::vector &ImpliesList = Feature->getValueAsListOfDefs("Implies"); - if (ImpliesList.empty()) { - OS << "{ }"; - } else { - OS << "{ "; - for (unsigned j = 0, M = ImpliesList.size(); j < M;) { - OS << Target << "::" << ImpliesList[j]->getName(); - if (++j < M) OS << ", "; - } - OS << " }"; + OS << "{"; + for (unsigned j = 0, M = ImpliesList.size(); j < M;) { + OS << " " << Target << "::" << ImpliesList[j]->getName(); + if (++j < M) OS << ","; } + OS << " }"; OS << " }"; ++NumFeatures; @@ -240,16 +236,12 @@ unsigned SubtargetEmitter::CPUKeyValues(raw_ostream &OS) { << "\"" << Name << "\", " << "\"Select the " << Name << " processor\", "; - if (FeatureList.empty()) { - OS << "{ }"; - } else { - OS << "{ "; - for (unsigned j = 0, M = FeatureList.size(); j < M;) { - OS << Target << "::" << FeatureList[j]->getName(); - if (++j < M) OS << ", "; - } - OS << " }"; + OS << "{"; + for (unsigned j = 0, M = FeatureList.size(); j < M;) { + OS << " " << Target << "::" << FeatureList[j]->getName(); + if (++j < M) OS << ","; } + OS << " }"; // The { } is for the "implies" section of this data structure. OS << ", { } }"; -- 2.34.1