From 07ce69ae7d218d526d69ffc3245ec94529b7aa1d Mon Sep 17 00:00:00 2001 From: Daniel Sanders Date: Tue, 9 Jun 2015 09:47:46 +0000 Subject: [PATCH] [ADT] Assert that SmallVectorBase::grow_pod() successfully reallocates memory. Summary: If malloc/realloc fails then the SmallVector becomes unusable since begin() and end() will return NULL. This is unlikely to occur but was the cause of recent bugpoint test failures on my machine. It is not clear whether not checking for malloc/realloc failure is a deliberate decision and adding checks has the potential to impact compiler performance. Therefore, this patch only adds the check to builds with assertions enabled for the moment. Reviewers: bkramer Reviewed By: bkramer Subscribers: bkramer, llvm-commits Differential Revision: http://reviews.llvm.org/D9520 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@239392 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/SmallVector.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Support/SmallVector.cpp b/lib/Support/SmallVector.cpp index f9c0e78270c..b931505bd6a 100644 --- a/lib/Support/SmallVector.cpp +++ b/lib/Support/SmallVector.cpp @@ -33,6 +33,7 @@ void SmallVectorBase::grow_pod(void *FirstEl, size_t MinSizeInBytes, // If this wasn't grown from the inline copy, grow the allocated space. NewElts = realloc(this->BeginX, NewCapacityInBytes); } + assert(NewElts && "Out of memory"); this->EndX = (char*)NewElts+CurSizeBytes; this->BeginX = NewElts; -- 2.34.1