From 10cf6a6a4bdc5a99813cc464030b93466842ffc2 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 25 Jul 2009 17:57:37 +0000 Subject: [PATCH] add the most expedient hack to fix PR4619, along with a testcase. Thanks to Rafael for the great example. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@77083 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/TargetAsmInfo.cpp | 5 +++++ test/CodeGen/X86/global-sections.ll | 8 ++++++++ 2 files changed, 13 insertions(+) create mode 100644 test/CodeGen/X86/global-sections.ll diff --git a/lib/Target/TargetAsmInfo.cpp b/lib/Target/TargetAsmInfo.cpp index 3edbe93e561..727c584e3a8 100644 --- a/lib/Target/TargetAsmInfo.cpp +++ b/lib/Target/TargetAsmInfo.cpp @@ -326,6 +326,11 @@ const Section *TargetAsmInfo::SectionForGlobal(const GlobalValue *GV) const { // FIXME: Use mangler interface (PR4584). std::string Name = Prefix+GV->getNameStr(); + + // Pick up the flags for the uniquing section. + // FIXME: HACK. + Flags |= getFlagsForNamedSection(Name.c_str()); + return getNamedSection(Name.c_str(), Flags); } } diff --git a/test/CodeGen/X86/global-sections.ll b/test/CodeGen/X86/global-sections.ll new file mode 100644 index 00000000000..0b4ed3b3604 --- /dev/null +++ b/test/CodeGen/X86/global-sections.ll @@ -0,0 +1,8 @@ +; RUN: llvm-as < %s | llc -mtriple=i386-unknown-linux-gnu | FileCheck %s -check-prefix=LINUX + +@G1 = common global i32 0 + +; LINUX: .type G1,@object +; LINUX: .section .gnu.linkonce.b.G1,"aw",@nobits +; LINUX: .comm G1,4,4 + -- 2.34.1