From 124991cc6779ac3088c5fd2e4ae91c2ba11f1470 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Sat, 14 Feb 2015 03:02:23 +0000 Subject: [PATCH] R600/SI: Fix VOP3b encoding on VI git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@229228 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/R600/SIInstrFormats.td | 3 --- lib/Target/R600/SIInstrInfo.td | 25 +++++++++++++++++-------- lib/Target/R600/VIInstrFormats.td | 26 ++++++++++++++++++++++++++ 3 files changed, 43 insertions(+), 11 deletions(-) diff --git a/lib/Target/R600/SIInstrFormats.td b/lib/Target/R600/SIInstrFormats.td index 16a35ffc737..ea6efd3a6be 100644 --- a/lib/Target/R600/SIInstrFormats.td +++ b/lib/Target/R600/SIInstrFormats.td @@ -556,9 +556,6 @@ class VOP1 op, dag outs, dag ins, string asm, list pattern> : class VOP2 op, dag outs, dag ins, string asm, list pattern> : VOP2Common , VOP2e; -class VOP3b op, dag outs, dag ins, string asm, list pattern> : - VOP3Common , VOP3be; - class VOPC op, dag ins, string asm, list pattern> : VOPCCommon , VOPCe ; diff --git a/lib/Target/R600/SIInstrInfo.td b/lib/Target/R600/SIInstrInfo.td index 8c0a7151050..1ce8918ac32 100644 --- a/lib/Target/R600/SIInstrInfo.td +++ b/lib/Target/R600/SIInstrInfo.td @@ -880,6 +880,16 @@ class VOP3_Real_vi op, dag outs, dag ins, string asm, string opName> : VOP3e_vi , SIMCInstr ; +class VOP3b_Real_si op, dag outs, dag ins, string asm, string opName> : + VOP3Common , + VOP3be , + SIMCInstr; + +class VOP3b_Real_vi op, dag outs, dag ins, string asm, string opName> : + VOP3Common , + VOP3be_vi , + SIMCInstr ; + multiclass VOP3_m pattern, string opName, int NumSrcArgs, bit HasMods = 1> { @@ -958,6 +968,8 @@ multiclass VOP3SI_2_m pattern, string opName, string revOp, bit HasMods = 1, bit UseFullOp = 0> { @@ -968,14 +980,11 @@ multiclass VOP3b_2_m , - VOP3DisableFields<1, 0, HasMods>, - SIMCInstr; - - // TODO: Do we need this VI variant here? - /*def _vi : VOP3b_vi , - VOP3DisableFields<1, 0, HasMods>, - SIMCInstr;*/ + def _si : VOP3b_Real_si , + VOP3DisableFields<1, 0, HasMods>; + + def _vi : VOP3b_Real_vi , + VOP3DisableFields<1, 0, HasMods>; } // End sdst = SIOperand.VCC, Defs = [VCC] } diff --git a/lib/Target/R600/VIInstrFormats.td b/lib/Target/R600/VIInstrFormats.td index 5285d18ced4..c2422351124 100644 --- a/lib/Target/R600/VIInstrFormats.td +++ b/lib/Target/R600/VIInstrFormats.td @@ -136,6 +136,32 @@ class VOP3e_vi op> : Enc64 { let Inst{63} = src2_modifiers{0}; } +class VOP3be_vi op> : Enc64 { + bits<8> vdst; + bits<2> src0_modifiers; + bits<9> src0; + bits<2> src1_modifiers; + bits<9> src1; + bits<2> src2_modifiers; + bits<9> src2; + bits<7> sdst; + bits<2> omod; + bits<1> clamp; + + let Inst{7-0} = vdst; + let Inst{14-8} = sdst; + let Inst{15} = clamp; + let Inst{25-16} = op; + let Inst{31-26} = 0x34; //encoding + let Inst{40-32} = src0; + let Inst{49-41} = src1; + let Inst{58-50} = src2; + let Inst{60-59} = omod; + let Inst{61} = src0_modifiers{0}; + let Inst{62} = src1_modifiers{0}; + let Inst{63} = src2_modifiers{0}; +} + class EXPe_vi : EXPe { let Inst{31-26} = 0x31; //encoding } -- 2.34.1