From 149d1a1894a92872ad5d28c452e813d34c3d2658 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Fri, 7 Jun 2013 18:05:03 +0000 Subject: [PATCH] Use isxdigit. Thanks to Benjamin Kramer for the suggestion. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@183540 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Object/YAML.cpp | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/Object/YAML.cpp b/lib/Object/YAML.cpp index e63bd5df27c..4e7f0890989 100644 --- a/lib/Object/YAML.cpp +++ b/lib/Object/YAML.cpp @@ -23,14 +23,6 @@ void yaml::ScalarTraits::output( Val.writeAsHex(Out); } -// Can't find this anywhere else in the codebase (clang has one, but it has -// some baggage). Deduplicate as required. -static bool isHexDigit(uint8_t C) { - return ('0' <= C && C <= '9') || - ('A' <= C && C <= 'F') || - ('a' <= C && C <= 'f'); -} - StringRef yaml::ScalarTraits::input( StringRef Scalar, void *, object::yaml::BinaryRef &Val) { if (Scalar.size() % 2 != 0) @@ -38,7 +30,7 @@ StringRef yaml::ScalarTraits::input( // TODO: Can we improve YAMLIO to permit a more accurate diagnostic here? // (e.g. a caret pointing to the offending character). for (unsigned I = 0, N = Scalar.size(); I != N; ++I) - if (!isHexDigit(Scalar[I])) + if (!isxdigit(Scalar[I])) return "BinaryRef hex string must contain only hex digits."; Val = object::yaml::BinaryRef(Scalar); return StringRef(); -- 2.34.1