From 1994ff405e9c1a8916ca41e093e786262af42b42 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Wed, 26 Sep 2012 10:28:58 +0200 Subject: [PATCH] USB: uas: fix locking Forgot to unlock in the uas_eh_task_mgmt error paths. Signed-off-by: Gerd Hoffmann Reported-by: Fengguang Wu Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/uas.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 15789097edd6..4218701bb45e 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -649,12 +649,14 @@ static int uas_eh_task_mgmt(struct scsi_cmnd *cmnd, shost_printk(KERN_INFO, shost, "%s: %s: submit sense urb failed\n", __func__, fname); + spin_unlock_irqrestore(&devinfo->lock, flags); return FAILED; } if (uas_submit_task_urb(cmnd, GFP_ATOMIC, function, tag)) { shost_printk(KERN_INFO, shost, "%s: %s: submit task mgmt urb failed\n", __func__, fname); + spin_unlock_irqrestore(&devinfo->lock, flags); return FAILED; } spin_unlock_irqrestore(&devinfo->lock, flags); -- 2.34.1