From 19b982dc8f1e2a81b34c9bd0b7c2bce92ba9413c Mon Sep 17 00:00:00 2001 From: Nicholas Ormrod Date: Wed, 29 Oct 2014 13:10:39 -0700 Subject: [PATCH] Fix multiple includes Summary: Add nolint comments to appropriate multiply-included files. Removed raw duplicates from StlVectorTest. Test Plan: fbconfig -r folly && fbmake runtests Ran arc lint, see no "included multiple times" messages Reviewed By: robbert@fb.com Subscribers: sdwilsh, njormrod, folly-diffs@ FB internal diff: D1644144 Tasks: 5486739 Signature: t1:1644144:1414599280:1e403ea3675d2173b249c4ce6db0dad621a139bc --- folly/FBString.h | 4 ++-- folly/test/FBStringBenchmark.cpp | 4 ++-- folly/test/FBVectorBenchmark.cpp | 8 ++++---- folly/test/stl_tests/StlVectorTest.cpp | 3 --- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/folly/FBString.h b/folly/FBString.h index e80eba59..3e7e292b 100644 --- a/folly/FBString.h +++ b/folly/FBString.h @@ -36,9 +36,9 @@ // either before or after this inclusion. #ifdef FOLLY_MALLOC_H_ #undef FOLLY_MALLOC_H_ -#include "basic_fbstring_malloc.h" +#include "basic_fbstring_malloc.h" // nolint #else -#include "basic_fbstring_malloc.h" +#include "basic_fbstring_malloc.h" // nolint #undef FOLLY_MALLOC_H_ #endif diff --git a/folly/test/FBStringBenchmark.cpp b/folly/test/FBStringBenchmark.cpp index 9539effe..d6800b87 100644 --- a/folly/test/FBStringBenchmark.cpp +++ b/folly/test/FBStringBenchmark.cpp @@ -86,10 +86,10 @@ std::list RandomList(unsigned int maxSize) { #define BENCHFUN(F) CONCAT(CONCAT(BM_, F), CONCAT(_, STRING)) #define STRING string -#include +#include // nolint #undef STRING #define STRING fbstring -#include +#include // nolint #undef STRING int main(int argc, char** argv) { diff --git a/folly/test/FBVectorBenchmark.cpp b/folly/test/FBVectorBenchmark.cpp index 2e20e39f..c5123f80 100644 --- a/folly/test/FBVectorBenchmark.cpp +++ b/folly/test/FBVectorBenchmark.cpp @@ -93,16 +93,16 @@ typedef vector FBStringVector; typedef fbvector FBStringFBVector; #define VECTOR IntVector -#include +#include // nolint #undef VECTOR #define VECTOR IntFBVector -#include +#include // nolint #undef VECTOR #define VECTOR FBStringVector -#include +#include // nolint #undef VECTOR #define VECTOR FBStringFBVector -#include +#include // nolint #undef VECTOR int main(int argc, char** argv) { diff --git a/folly/test/stl_tests/StlVectorTest.cpp b/folly/test/stl_tests/StlVectorTest.cpp index 6f68ec9e..c3cbd7c6 100644 --- a/folly/test/stl_tests/StlVectorTest.cpp +++ b/folly/test/stl_tests/StlVectorTest.cpp @@ -2729,9 +2729,6 @@ int main(int argc, char** argv) { #else // GCC 4.7 guard -#include -#include - // do nothing TEST(placeholder, gccversion) {} -- 2.34.1