From 1b4542b6df40aa6889e9af55f18e47edd93c62a0 Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Thu, 12 Jul 2007 17:52:20 +0000 Subject: [PATCH] Remove the end-block handling code. It was unsafe, and making it safe would have resulted in falling back to the slow DSE case. I need to think some more about the right way to handle this. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@39788 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/FastDSE.cpp | 55 ------------------------------- 1 file changed, 55 deletions(-) diff --git a/lib/Transforms/Scalar/FastDSE.cpp b/lib/Transforms/Scalar/FastDSE.cpp index f5c5c547a0c..dd47a190582 100644 --- a/lib/Transforms/Scalar/FastDSE.cpp +++ b/lib/Transforms/Scalar/FastDSE.cpp @@ -122,11 +122,6 @@ bool FDSE::runOnBasicBlock(BasicBlock &BB) { } } - // If this block ends in a return, unwind, unreachable, and eventually - // tailcall, then all allocas are dead at its end. - if (BB.getTerminator()->getNumSuccessors() == 0) - MadeChange |= handleEndBlock(BB, possiblyDead); - // Do a trivial DCE while (!possiblyDead.empty()) { Instruction *I = possiblyDead.back(); @@ -168,56 +163,6 @@ bool FDSE::handleFreeWithNonTrivialDependency(FreeInst* F, StoreInst* dependency return false; } -/// handleEndBlock - Remove dead stores to stack-allocated locations in the function -/// end block -bool FDSE::handleEndBlock(BasicBlock& BB, SetVector& possiblyDead) { - MemoryDependenceAnalysis &MD = getAnalysis(); - - bool MadeChange = false; - - // Pointers alloca'd in this function are dead in the end block - SmallPtrSet deadPointers; - - // Find all of the alloca'd pointers in the entry block - BasicBlock *Entry = BB.getParent()->begin(); - for (BasicBlock::iterator I = Entry->begin(), E = Entry->end(); I != E; ++I) - if (AllocaInst *AI = dyn_cast(I)) - deadPointers.insert(AI); - - // Scan the basic block backwards - for (BasicBlock::iterator BBI = BB.end(); BBI != BB.begin(); ){ - --BBI; - - if (deadPointers.empty()) - break; - - // If we find a store whose pointer is dead... - if (StoreInst* S = dyn_cast(BBI)) { - if (deadPointers.count(S->getPointerOperand())){ - // Remove it! - MD.removeInstruction(S); - - // DCE instructions only used to calculate that store - if (Instruction* D = dyn_cast(S->getOperand(0))) - possiblyDead.insert(D); - - BBI++; - S->eraseFromParent(); - NumFastStores++; - MadeChange = true; - } - - // If we encounter a use of the pointer, it is no longer considered dead - } else if (LoadInst* L = dyn_cast(BBI)) { - deadPointers.erase(L->getPointerOperand()); - } else if (VAArgInst* V = dyn_cast(BBI)) { - deadPointers.erase(V->getOperand(0)); - } - } - - return MadeChange; -} - void FDSE::DeleteDeadInstructionChains(Instruction *I, SetVector &DeadInsts) { // Instruction must be dead. -- 2.34.1