From 20263fdbfb77522f56df6521a1a09af214a1d7e0 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Tue, 20 Oct 2015 18:16:37 +0000 Subject: [PATCH] [CMake] All the checks for if LLVM_VERSION_* variables are set need to be if(DEFINED ...) This is because if you set one of the variables to 0, if(NOT ...) is true, which isn't what you actually want. Should have thought that through better the first time. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@250841 91177308-0d34-0410-b5e6-96231b3b80d8 --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 82e937e7ade..bbfd68d5590 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -26,13 +26,13 @@ else() set(cmake_3_2_USES_TERMINAL USES_TERMINAL) endif() -if(NOT LLVM_VERSION_MAJOR) +if(NOT DEFINED LLVM_VERSION_MAJOR) set(LLVM_VERSION_MAJOR 3) endif() -if(NOT LLVM_VERSION_MINOR) +if(NOT DEFINED LLVM_VERSION_MINOR) set(LLVM_VERSION_MINOR 8) endif() -if(NOT LLVM_VERSION_PATCH) +if(NOT DEFINED LLVM_VERSION_PATCH) set(LLVM_VERSION_PATCH 0) endif() if(NOT DEFINED LLVM_VERSION_SUFFIX) -- 2.34.1