From 204c953cd59415d7ed50b81c64906bf5a0c97455 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 18 Nov 2013 18:50:20 +0000 Subject: [PATCH] R600/SI: Fix illegal VGPR->SGPR copy inside of loop git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195026 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/R600/SIFixSGPRCopies.cpp | 3 +-- test/CodeGen/R600/sgpr-copy.ll | 31 +++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/lib/Target/R600/SIFixSGPRCopies.cpp b/lib/Target/R600/SIFixSGPRCopies.cpp index b49fda9689c..3370c7955bc 100644 --- a/lib/Target/R600/SIFixSGPRCopies.cpp +++ b/lib/Target/R600/SIFixSGPRCopies.cpp @@ -188,8 +188,7 @@ bool SIFixSGPRCopies::isVGPRToSGPRCopy(const MachineInstr &Copy, return false; SrcRC = inferRegClassFromDef(TRI, MRI, SrcReg, SrcSubReg); - return TRI->isSGPRClass(DstRC) && - !TRI->getCommonSubClass(DstRC, SrcRC); + return TRI->isSGPRClass(DstRC) && TRI->hasVGPRs(SrcRC); } bool SIFixSGPRCopies::runOnMachineFunction(MachineFunction &MF) { diff --git a/test/CodeGen/R600/sgpr-copy.ll b/test/CodeGen/R600/sgpr-copy.ll index 5ec1a089423..5472c1bb1ca 100644 --- a/test/CodeGen/R600/sgpr-copy.ll +++ b/test/CodeGen/R600/sgpr-copy.ll @@ -294,3 +294,34 @@ endif: store float %6, float addrspace(1)* %out ret void } + +; This test is just checking that we don't crash / assertion fail. +; CHECK-LABEL: @copy2 +; CHECK: S_ENDPGM + +define void @copy2([17 x <16 x i8>] addrspace(2)* byval, [32 x <16 x i8>] addrspace(2)* byval, [16 x <32 x i8>] addrspace(2)* byval, float inreg, i32 inreg, <2 x i32>, <2 x i32>, <2 x i32>, <3 x i32>, <2 x i32>, <2 x i32>, <2 x i32>, float, float, float, float, float, float, float, float, float) #0 { +entry: + br label %LOOP68 + +LOOP68: + %temp4.7 = phi float [ 0.000000e+00, %entry ], [ %v, %ENDIF69 ] + %t = phi i32 [ 20, %entry ], [ %x, %ENDIF69 ] + %g = icmp eq i32 0, %t + %l = bitcast float %temp4.7 to i32 + br i1 %g, label %IF70, label %ENDIF69 + +IF70: + %q = icmp ne i32 %l, 13 + %temp.8 = select i1 %q, float 1.000000e+00, float 0.000000e+00 + call void @llvm.SI.export(i32 15, i32 1, i32 1, i32 0, i32 0, float %temp.8, float 0.000000e+00, float 0.000000e+00, float 1.000000e+00) + ret void + +ENDIF69: + %u = add i32 %l, %t + %v = bitcast i32 %u to float + %x = add i32 %t, -1 + br label %LOOP68 +} + +attributes #0 = { "ShaderType"="0" } + -- 2.34.1