From 29b65fa1dffaf01292672588cf50c36485d993dc Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 5 Feb 2015 14:57:47 +0000 Subject: [PATCH] Add a FIXME. Thanks to Eric for the suggestion. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228300 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/TargetLoweringObjectFileImpl.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/CodeGen/TargetLoweringObjectFileImpl.cpp b/lib/CodeGen/TargetLoweringObjectFileImpl.cpp index 396d9e4fbfa..35860fa1337 100644 --- a/lib/CodeGen/TargetLoweringObjectFileImpl.cpp +++ b/lib/CodeGen/TargetLoweringObjectFileImpl.cpp @@ -181,6 +181,9 @@ getELFSectionFlags(SectionKind K, bool InCOMDAT) { if (K.isThreadLocal()) Flags |= ELF::SHF_TLS; + // FIXME: There is nothing in ELF preventing an SHF_MERGE from being + // in a comdat. We just avoid it for now because we don't print + // those .sections correctly. if (!InCOMDAT && (K.isMergeableCString() || K.isMergeableConst())) Flags |= ELF::SHF_MERGE; -- 2.34.1