From 35bb85b7ee108a265a20686e97d1b011f4ab5ce9 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Mon, 19 Apr 2010 22:51:14 +0000 Subject: [PATCH] Eliminate SelectionDAGISel's "current block" member. Just pass it as an argument to things that need it. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@101825 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/SelectionDAGISel.h | 8 ++--- lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp | 29 ++++++++++--------- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/include/llvm/CodeGen/SelectionDAGISel.h b/include/llvm/CodeGen/SelectionDAGISel.h index 03d9bf5a9a5..8fddb54452d 100644 --- a/include/llvm/CodeGen/SelectionDAGISel.h +++ b/include/llvm/CodeGen/SelectionDAGISel.h @@ -46,7 +46,6 @@ public: MachineRegisterInfo *RegInfo; SelectionDAG *CurDAG; SelectionDAGBuilder *SDB; - MachineBasicBlock *BB; AliasAnalysis *AA; GCFunctionInfo *GFI; CodeGenOpt::Level OptLevel; @@ -283,13 +282,14 @@ private: void PrepareEHLandingPad(MachineBasicBlock *BB); void SelectAllBasicBlocks(const Function &Fn); - void FinishBasicBlock(); + void FinishBasicBlock(MachineBasicBlock *BB); - void SelectBasicBlock(const BasicBlock *LLVMBB, + void SelectBasicBlock(MachineBasicBlock *BB, + const BasicBlock *LLVMBB, BasicBlock::const_iterator Begin, BasicBlock::const_iterator End, bool &HadTailCall); - void CodeGenAndEmitDAG(); + void CodeGenAndEmitDAG(MachineBasicBlock *BB); void LowerArguments(const BasicBlock *BB); void ShrinkDemandedOps(); diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp index ae39226153f..144abab772a 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp @@ -249,7 +249,8 @@ static void ResetDebugLoc(SelectionDAGBuilder *SDB, FastISel *FastIS) { FastIS->setCurDebugLoc(DebugLoc()); } -void SelectionDAGISel::SelectBasicBlock(const BasicBlock *LLVMBB, +void SelectionDAGISel::SelectBasicBlock(MachineBasicBlock *BB, + const BasicBlock *LLVMBB, BasicBlock::const_iterator Begin, BasicBlock::const_iterator End, bool &HadTailCall) { @@ -286,7 +287,7 @@ void SelectionDAGISel::SelectBasicBlock(const BasicBlock *LLVMBB, CurDAG->setRoot(SDB->getControlRoot()); // Final step, emit the lowered DAG as machine code. - CodeGenAndEmitDAG(); + CodeGenAndEmitDAG(BB); HadTailCall = SDB->HasTailCall; SDB->clear(); } @@ -473,7 +474,7 @@ void SelectionDAGISel::ComputeLiveOutVRegInfo() { } while (!Worklist.empty()); } -void SelectionDAGISel::CodeGenAndEmitDAG() { +void SelectionDAGISel::CodeGenAndEmitDAG(MachineBasicBlock *BB) { std::string GroupName; if (TimePassesIsEnabled) GroupName = "Instruction Selection and Scheduling"; @@ -754,7 +755,7 @@ void SelectionDAGISel::SelectAllBasicBlocks(const Function &Fn) { // Iterate over all basic blocks in the function. for (Function::const_iterator I = Fn.begin(), E = Fn.end(); I != E; ++I) { const BasicBlock *LLVMBB = &*I; - BB = FuncInfo->MBBMap[LLVMBB]; + MachineBasicBlock *BB = FuncInfo->MBBMap[LLVMBB]; BasicBlock::const_iterator const Begin = LLVMBB->begin(); BasicBlock::const_iterator const End = LLVMBB->end(); @@ -790,7 +791,7 @@ void SelectionDAGISel::SelectAllBasicBlocks(const Function &Fn) { // beginning FastISel on the entry block. if (LLVMBB == &Fn.getEntryBlock()) { CurDAG->setRoot(SDB->getControlRoot()); - CodeGenAndEmitDAG(); + CodeGenAndEmitDAG(BB); SDB->clear(); } FastIS->startNewBlock(BB); @@ -838,7 +839,7 @@ void SelectionDAGISel::SelectAllBasicBlocks(const Function &Fn) { } bool HadTailCall = false; - SelectBasicBlock(LLVMBB, BI, llvm::next(BI), HadTailCall); + SelectBasicBlock(BB, LLVMBB, BI, llvm::next(BI), HadTailCall); // If the call was emitted as a tail call, we're done with the block. if (HadTailCall) { @@ -874,17 +875,17 @@ void SelectionDAGISel::SelectAllBasicBlocks(const Function &Fn) { // block. if (BI != End) { bool HadTailCall; - SelectBasicBlock(LLVMBB, BI, End, HadTailCall); + SelectBasicBlock(BB, LLVMBB, BI, End, HadTailCall); } - FinishBasicBlock(); + FinishBasicBlock(BB); } delete FastIS; } void -SelectionDAGISel::FinishBasicBlock() { +SelectionDAGISel::FinishBasicBlock(MachineBasicBlock *BB) { DEBUG(dbgs() << "Target-post-processed machine code:\n"); DEBUG(BB->dump()); @@ -923,7 +924,7 @@ SelectionDAGISel::FinishBasicBlock() { // Emit the code SDB->visitBitTestHeader(SDB->BitTestCases[i], BB); CurDAG->setRoot(SDB->getRoot()); - CodeGenAndEmitDAG(); + CodeGenAndEmitDAG(BB); SDB->clear(); } @@ -944,7 +945,7 @@ SelectionDAGISel::FinishBasicBlock() { CurDAG->setRoot(SDB->getRoot()); - CodeGenAndEmitDAG(); + CodeGenAndEmitDAG(BB); SDB->clear(); } @@ -991,7 +992,7 @@ SelectionDAGISel::FinishBasicBlock() { SDB->visitJumpTableHeader(SDB->JTCases[i].second, SDB->JTCases[i].first, BB); CurDAG->setRoot(SDB->getRoot()); - CodeGenAndEmitDAG(); + CodeGenAndEmitDAG(BB); SDB->clear(); } @@ -1000,7 +1001,7 @@ SelectionDAGISel::FinishBasicBlock() { // Emit the code SDB->visitJumpTable(SDB->JTCases[i].second); CurDAG->setRoot(SDB->getRoot()); - CodeGenAndEmitDAG(); + CodeGenAndEmitDAG(BB); SDB->clear(); // Update PHI Nodes @@ -1048,7 +1049,7 @@ SelectionDAGISel::FinishBasicBlock() { // Emit the code SDB->visitSwitchCase(SDB->SwitchCases[i], BB); CurDAG->setRoot(SDB->getRoot()); - CodeGenAndEmitDAG(); + CodeGenAndEmitDAG(BB); // Handle any PHI nodes in successors of this chunk, as if we were coming // from the original BB before switch expansion. Note that PHI nodes can -- 2.34.1