From 36a716b7b1eb8879364d53cdf9d01346e8e493fe Mon Sep 17 00:00:00 2001
From: Tudor Bosman <tudorb@fb.com>
Date: Wed, 16 Jan 2013 14:52:04 -0800
Subject: [PATCH] set pid_=-1 after wait, actually implement pid()
Summary: minor issues in folly::Subprocess
Test Plan: subprocess_test
Reviewed By: philipp@fb.com
FB internal diff: D680959
---
folly/Subprocess.cpp | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/folly/Subprocess.cpp b/folly/Subprocess.cpp
index da69e536..1470a706 100644
--- a/folly/Subprocess.cpp
+++ b/folly/Subprocess.cpp
@@ -427,6 +427,7 @@ ProcessReturnCode Subprocess::wait() {
checkUnixError(found, "waitpid");
DCHECK_EQ(found, pid_);
returnCode_ = ProcessReturnCode(status);
+ pid_ = -1;
return returnCode_;
}
@@ -441,6 +442,10 @@ void Subprocess::sendSignal(int signal) {
checkUnixError(r, "kill");
}
+pid_t Subprocess::pid() const {
+ return pid_;
+}
+
namespace {
std::pair<const uint8_t*, size_t> queueFront(const IOBufQueue& queue) {
--
2.34.1