From 39fcd2305abd9d33685ffeaa6a69d35c98177e3d Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Fri, 13 Mar 2015 06:41:26 +0000 Subject: [PATCH] Fix an infinite recursion in the verifier caused by calling isSized on a recursive type. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@232143 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/IR/Verifier.cpp | 3 ++- test/Verifier/recursive-struct-param.ll | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 test/Verifier/recursive-struct-param.ll diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp index eaad5fb1b98..9e77c32ee4b 100644 --- a/lib/IR/Verifier.cpp +++ b/lib/IR/Verifier.cpp @@ -1014,7 +1014,8 @@ void Verifier::VerifyParameterAttrs(AttributeSet Attrs, unsigned Idx, Type *Ty, V); if (PointerType *PTy = dyn_cast(Ty)) { - if (!PTy->getElementType()->isSized()) { + SmallPtrSet Visited; + if (!PTy->getElementType()->isSized(&Visited)) { Assert(!Attrs.hasAttribute(Idx, Attribute::ByVal) && !Attrs.hasAttribute(Idx, Attribute::InAlloca), "Attributes 'byval' and 'inalloca' do not support unsized types!", diff --git a/test/Verifier/recursive-struct-param.ll b/test/Verifier/recursive-struct-param.ll new file mode 100644 index 00000000000..4b280a010f0 --- /dev/null +++ b/test/Verifier/recursive-struct-param.ll @@ -0,0 +1,15 @@ +; RUN: opt -verify < %s + +%struct.__sFILE = type { %struct.__sFILE } + +@.str = private unnamed_addr constant [13 x i8] c"Hello world\0A\00", align 1 + +; Function Attrs: nounwind ssp +define void @test(%struct.__sFILE* %stream, i8* %str) { + %fputs = call i32 @fputs(i8* %str, %struct.__sFILE* %stream) + ret void +} + +; Function Attrs: nounwind +declare i32 @fputs(i8* nocapture, %struct.__sFILE* nocapture) + -- 2.34.1