From 43a5634f46ef7cc4fab59f57400115f6e31be823 Mon Sep 17 00:00:00 2001 From: khizmax Date: Sun, 19 Mar 2017 10:50:17 +0300 Subject: [PATCH] uRCU: docfix, mark some virtual func as "override" --- cds/urcu/details/gpb.h | 8 +++++--- cds/urcu/details/gpi.h | 6 ++++-- cds/urcu/details/gpt.h | 6 ++++-- cds/urcu/details/sig_buffered.h | 6 ++++-- 4 files changed, 17 insertions(+), 9 deletions(-) diff --git a/cds/urcu/details/gpb.h b/cds/urcu/details/gpb.h index 697925da..0041f383 100644 --- a/cds/urcu/details/gpb.h +++ b/cds/urcu/details/gpb.h @@ -86,7 +86,9 @@ namespace cds { namespace urcu { typedef base_class::thread_gc thread_gc ; ///< Thread-side RCU part typedef typename thread_gc::scoped_lock scoped_lock ; ///< Access lock class - static bool const c_bBuffered = true ; ///< This RCU buffers disposed elements + //@cond + static bool const c_bBuffered = true ; ///< Bufferized RCU + //@endcond protected: //@cond @@ -146,7 +148,7 @@ namespace cds { namespace urcu { } } - // Return: true - synchronize has been called, false - otherwise + // Return: \p true - synchronize has been called, \p false - otherwise bool push_buffer( epoch_retired_ptr&& ep ) { bool bPushed = m_Buffer.push( ep ); @@ -191,7 +193,7 @@ namespace cds { namespace urcu { When the buffer becomes full \ref synchronize function is called to wait for the end of grace period and then to free all pointers from the buffer. */ - virtual void retire_ptr( retired_ptr& p ) + virtual void retire_ptr( retired_ptr& p ) override { if ( p.m_p ) push_buffer( epoch_retired_ptr( p, m_nCurEpoch.load( atomics::memory_order_relaxed ))); diff --git a/cds/urcu/details/gpi.h b/cds/urcu/details/gpi.h index a3a7da3c..560a002b 100644 --- a/cds/urcu/details/gpi.h +++ b/cds/urcu/details/gpi.h @@ -72,7 +72,9 @@ namespace cds { namespace urcu { typedef typename base_class::thread_gc thread_gc ; ///< Thread-side RCU part typedef typename thread_gc::scoped_lock scoped_lock ; ///< Access lock class - static bool const c_bBuffered = false ; ///< This RCU does not buffer disposed elements + //@cond + static bool const c_bBuffered = false ; ///< No buffers + //@endcond protected: //@cond @@ -137,7 +139,7 @@ namespace cds { namespace urcu { The method calls \p synchronize() to wait for the end of grace period and calls \p p disposer. */ - virtual void retire_ptr( retired_ptr& p ) + virtual void retire_ptr( retired_ptr& p ) override { synchronize(); if ( p.m_p ) diff --git a/cds/urcu/details/gpt.h b/cds/urcu/details/gpt.h index 111e03b8..45242443 100644 --- a/cds/urcu/details/gpt.h +++ b/cds/urcu/details/gpt.h @@ -99,7 +99,9 @@ namespace cds { namespace urcu { typedef base_class::thread_gc thread_gc ; ///< Access lock class typedef typename thread_gc::scoped_lock scoped_lock ; ///< Access lock class - static bool const c_bBuffered = true ; ///< This RCU buffers disposed elements + //@cond + static bool const c_bBuffered = true ; ///< Bufferized RCU + //@endcond protected: //@cond @@ -206,7 +208,7 @@ namespace cds { namespace urcu { to wait for the end of grace period and then a message is sent to the reclamation thread. */ - virtual void retire_ptr( retired_ptr& p ) + virtual void retire_ptr( retired_ptr& p ) override { if ( p.m_p ) push_buffer( epoch_retired_ptr( p, m_nCurEpoch.load( atomics::memory_order_acquire ))); diff --git a/cds/urcu/details/sig_buffered.h b/cds/urcu/details/sig_buffered.h index 9b940183..378c1b60 100644 --- a/cds/urcu/details/sig_buffered.h +++ b/cds/urcu/details/sig_buffered.h @@ -88,7 +88,9 @@ namespace cds { namespace urcu { typedef base_class::thread_gc thread_gc ; ///< Thread-side RCU part typedef typename thread_gc::scoped_lock scoped_lock ; ///< Access lock class - static bool const c_bBuffered = true ; ///< This RCU buffers disposed elements + //@cond + static bool const c_bBuffered = true ; ///< Bufferized RCU + //@endcond protected: //@cond @@ -189,7 +191,7 @@ namespace cds { namespace urcu { When the buffer becomes full \ref synchronize function is called to wait for the end of grace period and then to free all pointers from the buffer. */ - virtual void retire_ptr( retired_ptr& p ) + virtual void retire_ptr( retired_ptr& p ) override { if ( p.m_p ) push_buffer( epoch_retired_ptr( p, m_nCurEpoch.load( atomics::memory_order_relaxed ))); -- 2.34.1