From 45bedee32085fb6befb59d49cae3d3281394724b Mon Sep 17 00:00:00 2001 From: Lucian Grijincu Date: Mon, 1 Feb 2016 11:45:53 -0800 Subject: [PATCH] folly: ubsan: HashTest: avoid invalid shift (sanitize=shift) Summary: [ RUN ] Hash.TWang_Unmix64 folly/test/HashTest.cpp:125:20: runtime error: shift exponent 32 is too large for 32-bit type 'unsigned int' Reviewed By: philippv Differential Revision: D2886144 fb-gh-sync-id: 8d7963c087c9db34b08c07451d35e5568c750520 --- folly/test/HashTest.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/folly/test/HashTest.cpp b/folly/test/HashTest.cpp index de12b1e0..94993ddd 100644 --- a/folly/test/HashTest.cpp +++ b/folly/test/HashTest.cpp @@ -122,9 +122,9 @@ void checkTWang(uint64_t r) { TEST(Hash, TWang_Unmix64) { // We'll try (1 << i), (1 << i) + 1, (1 << i) - 1 for (int i = 1; i < 64; i++) { - checkTWang((1U << i) - 1); - checkTWang(1U << i); - checkTWang((1U << i) + 1); + checkTWang((uint64_t(1) << i) - 1); + checkTWang(uint64_t(1) << i); + checkTWang((uint64_t(1) << i) + 1); } } -- 2.34.1