From 47ddb76984521c2c62398dc454bcbdcf0a806005 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Tue, 20 Jan 2015 01:18:32 +0000 Subject: [PATCH] IR: Delete GenericDwarfNode during teardown Fix a leak in `LLVMContextImpl` teardown that the leak sanitizer tracked down [1]. I've just switched to automatic dispatch here (since I'll inevitably forget again with the next class). [1]: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/811/steps/check-llvm%20asan/logs/stdio git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@226536 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/IR/LLVMContextImpl.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/IR/LLVMContextImpl.cpp b/lib/IR/LLVMContextImpl.cpp index 81ff9a96f49..aa7242af997 100644 --- a/lib/IR/LLVMContextImpl.cpp +++ b/lib/IR/LLVMContextImpl.cpp @@ -78,10 +78,10 @@ LLVMContextImpl::~LLVMContextImpl() { // unnecessary RAUW when nodes are still unresolved. for (auto *I : DistinctMDNodes) I->dropAllReferences(); - for (auto *I : MDTuples) - I->dropAllReferences(); - for (auto *I : MDLocations) +#define HANDLE_MDNODE_LEAF(CLASS) \ + for (auto *I : CLASS##s) \ I->dropAllReferences(); +#include "llvm/IR/Metadata.def" // Also drop references that come from the Value bridges. for (auto &Pair : ValuesAsMetadata) @@ -92,10 +92,10 @@ LLVMContextImpl::~LLVMContextImpl() { // Destroy MDNodes. for (MDNode *I : DistinctMDNodes) I->deleteAsSubclass(); - for (MDTuple *I : MDTuples) - delete I; - for (MDLocation *I : MDLocations) +#define HANDLE_MDNODE_LEAF(CLASS) \ + for (CLASS *I : CLASS##s) \ delete I; +#include "llvm/IR/Metadata.def" // Free the constants. This is important to do here to ensure that they are // freed before the LeakDetector is torn down. -- 2.34.1