From 5027260ce6d222ea3bae2057a483862919bf3490 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Mon, 3 Aug 2015 17:36:22 +0000 Subject: [PATCH] Revert "-Wdeprecated-clean: Fix cases of violating the rule of 5 in ways that are deprecated in C++11" This reverts commit r243824. It broke the build on Windows. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@243888 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AsmParser/LLParser.cpp | 15 ++++++--------- lib/AsmParser/LLParser.h | 20 +++++++++----------- 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp index f098babb9f4..22e77b22892 100644 --- a/lib/AsmParser/LLParser.cpp +++ b/lib/AsmParser/LLParser.cpp @@ -13,7 +13,6 @@ #include "LLParser.h" #include "llvm/ADT/SmallPtrSet.h" -#include "llvm/ADT/STLExtras.h" #include "llvm/AsmParser/SlotMapping.h" #include "llvm/IR/AutoUpgrade.h" #include "llvm/IR/CallingConv.h" @@ -2459,10 +2458,9 @@ bool LLParser::ParseValID(ValID &ID, PerFunctionState *PFS) { ParseToken(lltok::rbrace, "expected end of struct constant")) return true; - ID.ConstantStructElts = make_unique(Elts.size()); + ID.ConstantStructElts = new Constant*[Elts.size()]; ID.UIntVal = Elts.size(); - memcpy(ID.ConstantStructElts.get(), Elts.data(), - Elts.size() * sizeof(Elts[0])); + memcpy(ID.ConstantStructElts, Elts.data(), Elts.size()*sizeof(Elts[0])); ID.Kind = ValID::t_ConstantStruct; return false; } @@ -2481,9 +2479,8 @@ bool LLParser::ParseValID(ValID &ID, PerFunctionState *PFS) { return true; if (isPackedStruct) { - ID.ConstantStructElts = make_unique(Elts.size()); - memcpy(ID.ConstantStructElts.get(), Elts.data(), - Elts.size() * sizeof(Elts[0])); + ID.ConstantStructElts = new Constant*[Elts.size()]; + memcpy(ID.ConstantStructElts, Elts.data(), Elts.size()*sizeof(Elts[0])); ID.UIntVal = Elts.size(); ID.Kind = ValID::t_PackedConstantStruct; return false; @@ -4088,8 +4085,8 @@ bool LLParser::ConvertValIDToValue(Type *Ty, ValID &ID, Value *&V, return Error(ID.Loc, "element " + Twine(i) + " of struct initializer doesn't match struct element type"); - V = ConstantStruct::get( - ST, makeArrayRef(ID.ConstantStructElts.get(), ID.UIntVal)); + V = ConstantStruct::get(ST, makeArrayRef(ID.ConstantStructElts, + ID.UIntVal)); } else return Error(ID.Loc, "constant expression type mismatch"); return false; diff --git a/lib/AsmParser/LLParser.h b/lib/AsmParser/LLParser.h index acbf6f9e5b8..0990e090b7c 100644 --- a/lib/AsmParser/LLParser.h +++ b/lib/AsmParser/LLParser.h @@ -55,24 +55,22 @@ namespace llvm { t_InlineAsm, // Value in FTy/StrVal/StrVal2/UIntVal. t_ConstantStruct, // Value in ConstantStructElts. t_PackedConstantStruct // Value in ConstantStructElts. - } Kind = t_LocalID; + } Kind; LLLexer::LocTy Loc; unsigned UIntVal; FunctionType *FTy; std::string StrVal, StrVal2; APSInt APSIntVal; - APFloat APFloatVal{0.0}; + APFloat APFloatVal; Constant *ConstantVal; - std::unique_ptr ConstantStructElts; - - ValID() = default; - ValID(ValID &&RHS) - : Kind(RHS.Kind), Loc(RHS.Loc), UIntVal(RHS.UIntVal), FTy(RHS.FTy), - StrVal(std::move(RHS.StrVal)), StrVal2(std::move(RHS.StrVal2)), - APSIntVal(std::move(RHS.APSIntVal)), - APFloatVal(std::move(RHS.APFloatVal)), ConstantVal(RHS.ConstantVal), - ConstantStructElts(std::move(RHS.ConstantStructElts)) {} + Constant **ConstantStructElts; + + ValID() : Kind(t_LocalID), APFloatVal(0.0) {} + ~ValID() { + if (Kind == t_ConstantStruct || Kind == t_PackedConstantStruct) + delete [] ConstantStructElts; + } bool operator<(const ValID &RHS) const { if (Kind == t_LocalID || Kind == t_GlobalID) -- 2.34.1