From 544df3651e15f31ae2c14588c1272fd870560250 Mon Sep 17 00:00:00 2001 From: Jakob Stoklund Olesen Date: Mon, 28 Sep 2009 20:32:46 +0000 Subject: [PATCH] Use KILL instead of IMPLICIT_DEF in LowerSubregs pass. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@83007 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/LowerSubregs.cpp | 21 ++++++++++----------- lib/CodeGen/PostRASchedulerList.cpp | 6 +++--- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/lib/CodeGen/LowerSubregs.cpp b/lib/CodeGen/LowerSubregs.cpp index f3157f008b9..8486bb084fe 100644 --- a/lib/CodeGen/LowerSubregs.cpp +++ b/lib/CodeGen/LowerSubregs.cpp @@ -126,11 +126,10 @@ bool LowerSubregsInstructionPass::LowerExtract(MachineInstr *MI) { if (SrcReg == DstReg) { // No need to insert an identity copy instruction. if (MI->getOperand(1).isKill()) { - // We must make sure the super-register gets killed.Replace the - // instruction with IMPLICIT_DEF. - MI->setDesc(TII.get(TargetInstrInfo::IMPLICIT_DEF)); + // We must make sure the super-register gets killed. Replace the + // instruction with KILL. + MI->setDesc(TII.get(TargetInstrInfo::KILL)); MI->RemoveOperand(2); // SubIdx - MI->getOperand(1).setImplicit(true); DEBUG(errs() << "subreg: replace by: " << *MI); return true; } @@ -243,14 +242,14 @@ bool LowerSubregsInstructionPass::LowerInsert(MachineInstr *MI) { if (DstSubReg == InsReg) { // No need to insert an identity copy instruction. If the SrcReg was - // , we need to make sure it is alive by inserting an IMPLICIT_DEF + // , we need to make sure it is alive by inserting a KILL if (MI->getOperand(1).isUndef() && !MI->getOperand(0).isDead()) { MachineInstrBuilder MIB = BuildMI(*MBB, MI, MI->getDebugLoc(), - TII.get(TargetInstrInfo::IMPLICIT_DEF), DstReg); + TII.get(TargetInstrInfo::KILL), DstReg); if (MI->getOperand(2).isUndef()) - MIB.addReg(InsReg, RegState::Implicit | RegState::Undef); + MIB.addReg(InsReg, RegState::Undef); else - MIB.addReg(InsReg, RegState::ImplicitKill); + MIB.addReg(InsReg, RegState::Kill); } else { DEBUG(errs() << "subreg: eliminated!\n"); MBB->erase(MI); @@ -261,10 +260,10 @@ bool LowerSubregsInstructionPass::LowerInsert(MachineInstr *MI) { const TargetRegisterClass *TRC0= TRI.getPhysicalRegisterRegClass(DstSubReg); const TargetRegisterClass *TRC1= TRI.getPhysicalRegisterRegClass(InsReg); if (MI->getOperand(2).isUndef()) - // If the source register being inserted is undef, then this becomes an - // implicit_def. + // If the source register being inserted is undef, then this becomes a + // KILL. BuildMI(*MBB, MI, MI->getDebugLoc(), - TII.get(TargetInstrInfo::IMPLICIT_DEF), DstSubReg); + TII.get(TargetInstrInfo::KILL), DstSubReg); else TII.copyRegToReg(*MBB, MI, DstSubReg, InsReg, TRC0, TRC1); MachineBasicBlock::iterator CopyMI = MI; diff --git a/lib/CodeGen/PostRASchedulerList.cpp b/lib/CodeGen/PostRASchedulerList.cpp index 0f2d3095ac0..9d75b25b82c 100644 --- a/lib/CodeGen/PostRASchedulerList.cpp +++ b/lib/CodeGen/PostRASchedulerList.cpp @@ -655,11 +655,11 @@ bool SchedulePostRATDList::BreakAntiDependencies() { I != E; --Count) { MachineInstr *MI = --I; - // After regalloc, IMPLICIT_DEF instructions aren't safe to treat as - // dependence-breaking. In the case of an INSERT_SUBREG, the IMPLICIT_DEF + // After regalloc, KILL instructions aren't safe to treat as + // dependence-breaking. In the case of an INSERT_SUBREG, the KILL // is left behind appearing to clobber the super-register, while the // subregister needs to remain live. So we just ignore them. - if (MI->getOpcode() == TargetInstrInfo::IMPLICIT_DEF) + if (MI->getOpcode() == TargetInstrInfo::KILL) continue; // Check if this instruction has a dependence on the critical path that -- 2.34.1