From 56fa307e514c4a792a821595c4fdb48d8b591fc5 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Mon, 21 Sep 2015 18:02:24 +0000 Subject: [PATCH] [ADT] Remove a couple of the always inline attributes I added. Based on conversations with Justin and a few others, these constructors are really useful to have in the executable so that you can call them from the debugger. After some measurements, these *particular* calls aren't so problematic as to make them a good tradeoff for always inline. Please let me know if there are other functions really needed for debugging. The always inline attribute is a hack that we should only really employ when it doesn't hurt. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@248188 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/ADT/StringRef.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/llvm/ADT/StringRef.h b/include/llvm/ADT/StringRef.h index bc80946a9ea..350032b8c4e 100644 --- a/include/llvm/ADT/StringRef.h +++ b/include/llvm/ADT/StringRef.h @@ -65,11 +65,9 @@ namespace llvm { /// @{ /// Construct an empty string ref. - LLVM_ATTRIBUTE_ALWAYS_INLINE /*implicit*/ StringRef() : Data(nullptr), Length(0) {} /// Construct a string ref from a cstring. - LLVM_ATTRIBUTE_ALWAYS_INLINE /*implicit*/ StringRef(const char *Str) : Data(Str) { assert(Str && "StringRef cannot be built from a NULL argument"); -- 2.34.1