From 581a7ad7c9e801522b6f137eebd8787e486292ef Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Fri, 5 May 2006 20:51:30 +0000 Subject: [PATCH] Fix an infinite loop compiling oggenc last night. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@28128 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/InstructionCombining.cpp | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 2c8f6eda495..6491ff9b0f7 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -2642,9 +2642,10 @@ Instruction *InstCombiner::visitAnd(BinaryOperator &I) { // fold (and (cast A), (cast B)) -> (cast (and A, B)) if (CastInst *Op0C = dyn_cast(Op0)) { + const Type *SrcTy = Op0C->getOperand(0)->getType(); if (CastInst *Op1C = dyn_cast(Op1)) - if (Op0C->getOperand(0)->getType() == Op1C->getOperand(0)->getType() && - Op0C->getOperand(0)->getType()->isIntegral()) { + if (SrcTy == Op1C->getOperand(0)->getType() && SrcTy->isIntegral() && + !SrcTy->isLosslesslyConvertibleTo(Op0C->getType())) { Instruction *NewOp = BinaryOperator::createAnd(Op0C->getOperand(0), Op1C->getOperand(0), I.getName()); @@ -2881,9 +2882,10 @@ Instruction *InstCombiner::visitOr(BinaryOperator &I) { // fold (or (cast A), (cast B)) -> (cast (or A, B)) if (CastInst *Op0C = dyn_cast(Op0)) { + const Type *SrcTy = Op0C->getOperand(0)->getType(); if (CastInst *Op1C = dyn_cast(Op1)) - if (Op0C->getOperand(0)->getType() == Op1C->getOperand(0)->getType() && - Op0C->getOperand(0)->getType()->isIntegral()) { + if (SrcTy == Op1C->getOperand(0)->getType() && SrcTy->isIntegral() && + !SrcTy->isLosslesslyConvertibleTo(Op0C->getType())) { Instruction *NewOp = BinaryOperator::createOr(Op0C->getOperand(0), Op1C->getOperand(0), I.getName()); @@ -3059,9 +3061,10 @@ Instruction *InstCombiner::visitXor(BinaryOperator &I) { // fold (xor (cast A), (cast B)) -> (cast (xor A, B)) if (CastInst *Op0C = dyn_cast(Op0)) { + const Type *SrcTy = Op0C->getOperand(0)->getType(); if (CastInst *Op1C = dyn_cast(Op1)) - if (Op0C->getOperand(0)->getType() == Op1C->getOperand(0)->getType() && - Op0C->getOperand(0)->getType()->isIntegral()) { + if (SrcTy == Op1C->getOperand(0)->getType() && SrcTy->isIntegral() && + !SrcTy->isLosslesslyConvertibleTo(Op0C->getType())) { Instruction *NewOp = BinaryOperator::createXor(Op0C->getOperand(0), Op1C->getOperand(0), I.getName()); -- 2.34.1