From 5891510167361f8d7755f874ae669b1cb01d05ee Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Mon, 10 Aug 2015 16:43:20 +0000 Subject: [PATCH] fix minsize detection: minsize attribute implies optimizing for size git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@244458 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/X86ISelLowering.cpp | 4 +--- test/CodeGen/X86/splat-for-size.ll | 13 +++++++------ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index 5b0161df4bd..b6f34bd3a18 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -5188,9 +5188,7 @@ static SDValue LowerVectorBroadcast(SDValue Op, const X86Subtarget* Subtarget, // TODO: If multiple splats are generated to load the same constant, // it may be detrimental to overall size. There needs to be a way to detect // that condition to know if this is truly a size win. - const Function *F = DAG.getMachineFunction().getFunction(); - // FIXME: Use Function::optForSize(). - bool OptForSize = F->hasFnAttribute(Attribute::OptimizeForSize); + bool OptForSize = DAG.getMachineFunction().getFunction()->optForSize(); // Handle broadcasting a single constant scalar from the constant pool // into a vector. diff --git a/test/CodeGen/X86/splat-for-size.ll b/test/CodeGen/X86/splat-for-size.ll index 635aa821d78..916410a6244 100644 --- a/test/CodeGen/X86/splat-for-size.ll +++ b/test/CodeGen/X86/splat-for-size.ll @@ -14,7 +14,7 @@ define <2 x double> @splat_v2f64(<2 x double> %x) #0 { ; CHECK-NEXT: retq } -define <4 x double> @splat_v4f64(<4 x double> %x) #0 { +define <4 x double> @splat_v4f64(<4 x double> %x) #1 { %add = fadd <4 x double> %x, ret <4 x double> %add ; CHECK-LABEL: splat_v4f64 @@ -32,7 +32,7 @@ define <4 x float> @splat_v4f32(<4 x float> %x) #0 { ; CHECK-NEXT: retq } -define <8 x float> @splat_v8f32(<8 x float> %x) #0 { +define <8 x float> @splat_v8f32(<8 x float> %x) #1 { %add = fadd <8 x float> %x, ret <8 x float> %add ; CHECK-LABEL: splat_v8f32 @@ -67,7 +67,7 @@ define <4 x i64> @splat_v4i64(<4 x i64> %x) #0 { } ; AVX can't do integer splats, so fake it: use vbroadcastss to splat 32-bit value. -define <4 x i32> @splat_v4i32(<4 x i32> %x) #0 { +define <4 x i32> @splat_v4i32(<4 x i32> %x) #1 { %add = add <4 x i32> %x, ret <4 x i32> %add ; CHECK-LABEL: splat_v4i32 @@ -91,7 +91,7 @@ define <8 x i32> @splat_v8i32(<8 x i32> %x) #0 { } ; AVX can't do integer splats, and there's no broadcast fakery for 16-bit. Could use pshuflw, etc? -define <8 x i16> @splat_v8i16(<8 x i16> %x) #0 { +define <8 x i16> @splat_v8i16(<8 x i16> %x) #1 { %add = add <8 x i16> %x, ret <8 x i16> %add ; CHECK-LABEL: splat_v8i16 @@ -115,7 +115,7 @@ define <16 x i16> @splat_v16i16(<16 x i16> %x) #0 { } ; AVX can't do integer splats, and there's no broadcast fakery for 8-bit. Could use pshufb, etc? -define <16 x i8> @splat_v16i8(<16 x i8> %x) #0 { +define <16 x i8> @splat_v16i8(<16 x i8> %x) #1 { %add = add <16 x i8> %x, ret <16 x i8> %add ; CHECK-LABEL: splat_v16i8 @@ -144,7 +144,7 @@ define <32 x i8> @splat_v32i8(<32 x i8> %x) #0 { @A = common global <3 x i64> zeroinitializer, align 32 -define <8 x i64> @pr23259() #0 { +define <8 x i64> @pr23259() #1 { entry: %0 = load <4 x i64>, <4 x i64>* bitcast (<3 x i64>* @A to <4 x i64>*), align 32 %1 = shufflevector <4 x i64> %0, <4 x i64> undef, <3 x i32> @@ -153,3 +153,4 @@ entry: } attributes #0 = { optsize } +attributes #1 = { minsize } -- 2.34.1