From 5c2f37dddd963df61aed14283adb98067fb6afe5 Mon Sep 17 00:00:00 2001 From: Paul Gortmaker Date: Mon, 12 Dec 2011 21:47:38 -0500 Subject: [PATCH] serial: make FSL errata depend on 8250_CONSOLE, not just 8250 The recent commit "serial: add irq handler for Freescale 16550 errata" would allow Kconfig choices that had 8250 support as a module and yet still try and build in the errata fix non-modular, resulting in build failures for some non-embedded PPC targets. Since we hook in the errata fix from legacy_serial.c, which is built only for PPC_UDBG_16550, and since the errata is only really relevant for SysRQ on serial console, tighten up the dependencies to be exactly that. We'll get coverage on the relevant Freescale boards because the Kconfig for their CPU types all select the PPC_UDBG_16550 option, and the defconfigs also all select the 8250_CONSOLE option. Also, the 8250_CONSOLE option has a strict dependency on "SERIAL_8250=y" which resolves the reported problem for non Freescale targets. Reported-by: Michael Neuling Signed-off-by: Paul Gortmaker Tested-by: Michael Neuling Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index fee9e04f42e7..d1e4f203ae61 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -99,7 +99,7 @@ config SERIAL_8250_PNP config SERIAL_8250_FSL bool - depends on SERIAL_8250 && PPC + depends on SERIAL_8250_CONSOLE && PPC_UDBG_16550 default PPC config SERIAL_8250_HP300 -- 2.34.1