From 5eeb75092e8eb24798907a39381f64c3404cbe56 Mon Sep 17 00:00:00 2001 From: Philip Pronin Date: Tue, 10 Jul 2012 01:27:50 -0700 Subject: [PATCH] fix memory order in AtomicHashMap<>::findInternal() Summary: Looks like a typo, it should obviously be std::memory_order_relaxed (all necessary synchronization is done on numMapsAllocated_). Test Plan: compiled it, ran tests Reviewed By: sahrens@fb.com FB internal diff: D515322 --- folly/AtomicHashMap-inl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/AtomicHashMap-inl.h b/folly/AtomicHashMap-inl.h index f2738649..01919f24 100644 --- a/folly/AtomicHashMap-inl.h +++ b/folly/AtomicHashMap-inl.h @@ -163,7 +163,7 @@ findInternal(const KeyT k) const { int const numMaps = numMapsAllocated_.load(std::memory_order_acquire); FOR_EACH_RANGE(i, 1, numMaps) { // Check each map successively. If one succeeds, we're done! - SubMap* thisMap = subMaps_[i].load(std::memory_order_release); + SubMap* thisMap = subMaps_[i].load(std::memory_order_relaxed); ret = thisMap->findInternal(k); if (LIKELY(ret.idx != thisMap->capacity_)) { return SimpleRetT(i, ret.idx, ret.success); -- 2.34.1