From 5f8cb2a28a75acb85d8e96c6f5af157506ae08d6 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 14 Sep 2005 02:11:12 +0000 Subject: [PATCH] Add some more checking/verification code git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@23344 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/TableGen/DAGISelEmitter.cpp | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/utils/TableGen/DAGISelEmitter.cpp b/utils/TableGen/DAGISelEmitter.cpp index 22031b3f034..95a7ca070b1 100644 --- a/utils/TableGen/DAGISelEmitter.cpp +++ b/utils/TableGen/DAGISelEmitter.cpp @@ -654,8 +654,12 @@ void DAGISelEmitter::ParseAndResolveInstructions() { I->error("Could not infer all types in pattern!"); } + // SetDestinations - Keep track of all the virtual registers that are 'set' + // in the instruction, including what reg class they are. + std::map SetDestinations; + // Verify that the top-level forms in the instruction are of void type, and - // figure out how many of the instruction operands are destinations. + // fill in the SetDestinations map. for (unsigned j = 0, e = I->getNumTrees(); j != e; ++j) { TreePatternNode *Pat = I->getTree(j); if (Pat->getType() != MVT::isVoid) { @@ -677,16 +681,29 @@ void DAGISelEmitter::ParseAndResolveInstructions() { TreePatternNode *Dest = Pat->getChild(i); if (!Dest->isLeaf()) I->error("set destination should be a virtual register!"); - + DefInit *Val = dynamic_cast(Dest->getLeafValue()); if (!Val) I->error("set destination should be a virtual register!"); if (!Val->getDef()->isSubClassOf("RegisterClass")) I->error("set destination should be a virtual register!"); + if (Dest->getName().empty()) + I->error("set destination must have a name!"); + if (SetDestinations.count(Dest->getName())) + I->error("cannot set '" + Dest->getName() +"' multiple times"); + SetDestinations[Dest->getName()] = Val->getDef(); } } } + + // Now that we have operands that are sets, inspect the operands list for + // the instruction. This determines the order that operands are added to + // the machine instruction the node corresponds to. + assert(SetDestinations.size() == 1 && + "This code only handles a single set right now!"); + + DEBUG(I->dump()); Instructions.push_back(I); -- 2.34.1