From 60e32b07768631ef3e2af4811dee39951ae633c8 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 21 Sep 2006 05:46:00 +0000 Subject: [PATCH] Fit in 80-cols git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30556 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/README.txt | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/Target/X86/README.txt b/lib/Target/X86/README.txt index d2aaa592e6b..cc689c4a857 100644 --- a/lib/Target/X86/README.txt +++ b/lib/Target/X86/README.txt @@ -544,9 +544,9 @@ entry: br label %cond_true cond_true: ; preds = %cond_true, %entry - %x.0.0 = phi int [ 0, %entry ], [ %tmp9, %cond_true ] ; [#uses=3] - %t_addr.0.0 = phi int [ %t, %entry ], [ %tmp7, %cond_true ] ; [#uses=1] - %tmp2 = getelementptr int* %a, int %x.0.0 ; [#uses=1] + %x.0.0 = phi int [ 0, %entry ], [ %tmp9, %cond_true ] + %t_addr.0.0 = phi int [ %t, %entry ], [ %tmp7, %cond_true ] + %tmp2 = getelementptr int* %a, int %x.0.0 %tmp3 = load int* %tmp2 ; [#uses=1] %tmp5 = add int %t_addr.0.0, %x.0.0 ; [#uses=1] %tmp7 = add int %tmp5, %tmp3 ; [#uses=2] @@ -633,11 +633,12 @@ LBB1_1: #bb LBB1_2: #UnifiedReturnBlock ret -In the code above, the 'if' is turned into a 'switch' at the mid-level. It looks -like the 'lower to branches' mode could be improved a little here. In particular, -the fall-through to LBB1_3 doesn't need a branch. It would also be nice to -eliminate the redundant "cmp 6", maybe by lowering to a linear sequence of -compares if there are below a certain number of cases (instead of a binary sequence)? +In the code above, the 'if' is turned into a 'switch' at the mid-level. It +looks like the 'lower to branches' mode could be improved a little here. In +particular, the fall-through to LBB1_3 doesn't need a branch. It would also be +nice to eliminate the redundant "cmp 6", maybe by lowering to a linear sequence +of compares if there are below a certain number of cases (instead of a binary +sequence)? //===---------------------------------------------------------------------===// @@ -645,7 +646,7 @@ Compile: int %test(ulong *%tmp) { %tmp = load ulong* %tmp ; [#uses=1] %tmp.mask = shr ulong %tmp, ubyte 50 ; [#uses=1] - %tmp.mask = cast ulong %tmp.mask to ubyte ; [#uses=1] + %tmp.mask = cast ulong %tmp.mask to ubyte %tmp2 = and ubyte %tmp.mask, 3 ; [#uses=1] %tmp2 = cast ubyte %tmp2 to int ; [#uses=1] ret int %tmp2 -- 2.34.1