From 616842014ae7ca8f6ada6083087eb661b0313a56 Mon Sep 17 00:00:00 2001 From: Christopher Dykes Date: Fri, 14 Jul 2017 15:17:31 -0700 Subject: [PATCH] Switch future's Core to std::is_nothrow_constructible Summary: MSVC has issues with the way it was written, so just use the standard version instead. Upstream bug report: https://developercommunity.visualstudio.com/content/problem/80433/incorrect-error-c2462-cannot-define-a-type-in-a-ne.html Reviewed By: yfeldblum Differential Revision: D5427029 fbshipit-source-id: ae3737175d5b8e9738ed6b9573412d1d566b0e1c --- folly/futures/detail/Core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/futures/detail/Core.h b/folly/futures/detail/Core.h index dc91729f..6cbdebba 100644 --- a/folly/futures/detail/Core.h +++ b/folly/futures/detail/Core.h @@ -91,7 +91,7 @@ class Core final { template explicit Core(in_place_t, Args&&... args) noexcept( - noexcept(::new (nullptr) T(std::declval()...))) + std::is_nothrow_constructible::value) : result_(in_place, in_place, std::forward(args)...), fsm_(State::OnlyResult), attached_(1) {} -- 2.34.1