From 63cdcaa3d6c33cc1923797259bb8e5d9d9a899b1 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 4 Aug 2007 01:07:49 +0000 Subject: [PATCH] avoid an unneeded vector copy. This speeds up mem2reg on the testcase in PR1432 by 6% git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@40803 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Utils/PromoteMemoryToRegister.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/Transforms/Utils/PromoteMemoryToRegister.cpp b/lib/Transforms/Utils/PromoteMemoryToRegister.cpp index e4d541a0dd2..bb4b599fbaf 100644 --- a/lib/Transforms/Utils/PromoteMemoryToRegister.cpp +++ b/lib/Transforms/Utils/PromoteMemoryToRegister.cpp @@ -76,11 +76,18 @@ namespace { // Data package used by RenamePass() class VISIBILITY_HIDDEN RenamePassData { public: + RenamePassData() {} RenamePassData(BasicBlock *B, BasicBlock *P, const std::vector &V) : BB(B), Pred(P), Values(V) {} BasicBlock *BB; BasicBlock *Pred; std::vector Values; + + void swap(RenamePassData &RHS) { + std::swap(BB, RHS.BB); + std::swap(Pred, RHS.Pred); + Values.swap(RHS.Values); + } }; struct VISIBILITY_HIDDEN PromoteMem2Reg { @@ -406,7 +413,8 @@ void PromoteMem2Reg::run() { std::vector RenamePassWorkList; RenamePassWorkList.push_back(RenamePassData(F.begin(), 0, Values)); while(!RenamePassWorkList.empty()) { - RenamePassData RPD = RenamePassWorkList.back(); + RenamePassData RPD; + RPD.swap(RenamePassWorkList.back()); RenamePassWorkList.pop_back(); // RenamePass may add new worklist entries. RenamePass(RPD.BB, RPD.Pred, RPD.Values, RenamePassWorkList); -- 2.34.1