From 65b5c3d26e0b15814cfa0358c46f5335586bc48a Mon Sep 17 00:00:00 2001 From: Christopher Dykes Date: Fri, 3 Jun 2016 17:42:35 -0700 Subject: [PATCH] Remove a couple of MSVC portability defines Summary: The first is both wrong (due to the difference in semantics) and unneeded, as MSVC 2015 supports `snprintf` natively and with the correct semantics. The second is simply never used. Reviewed By: yfeldblum Differential Revision: D3387551 fbshipit-source-id: ea666a60ce859a59ad3d3ff961b4d7d642fd86eb --- folly/Portability.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/folly/Portability.h b/folly/Portability.h index 55c5dd5c..61c69846 100644 --- a/folly/Portability.h +++ b/folly/Portability.h @@ -256,13 +256,6 @@ namespace std { typedef ::max_align_t max_align_t; } #ifdef _MSC_VER #include -// sprintf semantics are not exactly identical -// but current usage is not a problem -# define snprintf _snprintf - -// semantics here are identical -# define strerror_r(errno,buf,len) strerror_s(buf,len,errno) - // compiler specific to compiler specific // nolint # define __PRETTY_FUNCTION__ __FUNCSIG__ -- 2.34.1