From 6725cb5f1c1b59cbd71dc221623c7b4cabafafd0 Mon Sep 17 00:00:00 2001 From: Gabor Greif Date: Wed, 11 Jun 2008 21:38:51 +0000 Subject: [PATCH] op_iterator-ify some loops, fix 80col violations git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@52226 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/LoopStrengthReduce.cpp | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/Transforms/Scalar/LoopStrengthReduce.cpp b/lib/Transforms/Scalar/LoopStrengthReduce.cpp index ad3d9d2ca43..cc5da5dd538 100644 --- a/lib/Transforms/Scalar/LoopStrengthReduce.cpp +++ b/lib/Transforms/Scalar/LoopStrengthReduce.cpp @@ -246,8 +246,8 @@ DeleteTriviallyDeadInstructions(SmallPtrSet &Insts) { } if (isInstructionTriviallyDead(I)) { - for (unsigned i = 0, e = I->getNumOperands(); i != e; ++i) - if (Instruction *U = dyn_cast(I->getOperand(i))) + for (User::op_iterator i = I->op_begin(), e = I->op_end(); i != e; ++i) + if (Instruction *U = dyn_cast(*i)) Insts.insert(U); SE->deleteValueFromRecords(I); I->eraseFromParent(); @@ -289,24 +289,25 @@ SCEVHandle LoopStrengthReduce::GetExpressionSCEV(Instruction *Exp) { gep_type_iterator GTI = gep_type_begin(GEP); - for (unsigned i = 1, e = GEP->getNumOperands(); i != e; ++i, ++GTI) { + for (User::op_iterator i = GEP->op_begin() + 1, e = GEP->op_end(); + i != e; ++i, ++GTI) { // If this is a use of a recurrence that we can analyze, and it comes before // Op does in the GEP operand list, we will handle this when we process this // operand. if (const StructType *STy = dyn_cast(*GTI)) { const StructLayout *SL = TD->getStructLayout(STy); - unsigned Idx = cast(GEP->getOperand(i))->getZExtValue(); + unsigned Idx = cast(*i)->getZExtValue(); uint64_t Offset = SL->getElementOffset(Idx); GEPVal = SE->getAddExpr(GEPVal, SE->getIntegerSCEV(Offset, UIntPtrTy)); } else { unsigned GEPOpiBits = - GEP->getOperand(i)->getType()->getPrimitiveSizeInBits(); + (*i)->getType()->getPrimitiveSizeInBits(); unsigned IntPtrBits = UIntPtrTy->getPrimitiveSizeInBits(); Instruction::CastOps opcode = (GEPOpiBits < IntPtrBits ? Instruction::SExt : (GEPOpiBits > IntPtrBits ? Instruction::Trunc : Instruction::BitCast)); - Value *OpVal = getCastedVersionOf(opcode, GEP->getOperand(i)); + Value *OpVal = getCastedVersionOf(opcode, *i); SCEVHandle Idx = SE->getSCEV(OpVal); uint64_t TypeSize = TD->getABITypeSize(GTI.getIndexedType()); @@ -628,7 +629,8 @@ void BasedUser::RewriteInstructionToUseNewBase(const SCEVHandle &NewBase, if (NewBasePt && isa(OperandValToReplace)) { InsertPt = NewBasePt; ++InsertPt; - } else if (Instruction *OpInst = dyn_cast(OperandValToReplace)) { + } else if (Instruction *OpInst + = dyn_cast(OperandValToReplace)) { InsertPt = OpInst; while (isa(InsertPt)) ++InsertPt; } @@ -1593,8 +1595,8 @@ ICmpInst *LoopStrengthReduce::ChangeCompareStride(Loop *L, ICmpInst *Cond, ? UIntPtrTy->getPrimitiveSizeInBits() : NewCmpTy->getPrimitiveSizeInBits(); if (RequiresTypeConversion(NewCmpTy, CmpTy)) { - // Check if it is possible to rewrite it using a iv / stride of a smaller - // integer type. + // Check if it is possible to rewrite it using + // an iv / stride of a smaller integer type. bool TruncOk = false; if (NewCmpTy->isInteger()) { unsigned Bits = NewTyBits; -- 2.34.1