From 67ea6a711179441ffbc5ac34d14978fc3f546b99 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 1 Mar 2010 22:49:06 +0000 Subject: [PATCH] resolve some fixmes git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@97515 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/TableGen/DAGISelMatcherGen.cpp | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/utils/TableGen/DAGISelMatcherGen.cpp b/utils/TableGen/DAGISelMatcherGen.cpp index 260d4df5888..c0f04deb55f 100644 --- a/utils/TableGen/DAGISelMatcherGen.cpp +++ b/utils/TableGen/DAGISelMatcherGen.cpp @@ -36,12 +36,9 @@ static MVT::SimpleValueType getRegisterValueType(Record *R, VT = RC.getValueTypeNum(0); continue; } - - // In multiple RC's. If the Types of the RC's do not agree, return - // MVT::Other. The target is responsible for handling this. - if (VT != RC.getValueTypeNum(0)) - // FIXME2: when does this happen? Abort? - return MVT::Other; + + // If this occurs in multiple register classes, they all have to agree. + assert(VT == RC.getValueTypeNum(0)); } return VT; } @@ -849,10 +846,6 @@ void MatcherGen::EmitResultCode() { AddMatcher(new MarkFlagResultsMatcher(MatchedFlagResultNodes.data(), MatchedFlagResultNodes.size())); - - // We know that the resulting pattern has exactly one result/ - // FIXME2: why? what about something like (set a,b,c, (complexpat)) - // FIXME2: Implicit results should be pushed here I guess? AddMatcher(new CompleteMatchMatcher(Ops.data(), Ops.size(), Pattern)); } -- 2.34.1