From 6826114d6e10725d122dca9352dc2d99a0f693e9 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Tue, 24 Aug 2010 14:35:45 +0000 Subject: [PATCH] Add a comment explaining why this code doesn't just call ParseMetadataValue. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@111914 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AsmParser/LLParser.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp index 0eb1b70c3f2..7766ad61da1 100644 --- a/lib/AsmParser/LLParser.cpp +++ b/lib/AsmParser/LLParser.cpp @@ -1134,6 +1134,10 @@ bool LLParser::ParseInstructionMetadata(Instruction *Inst, if (ParseToken(lltok::exclaim, "expected '!' here")) return true; + // This code is similar to that of ParseMetadataValue, however it needs to + // have special-case code for a forward reference; see the comments on + // ForwardRefInstMetadata for details. Also, MDStrings are not supported + // at the top level here. if (Lex.getKind() == lltok::lbrace) { ValID ID; if (ParseMetadataListValue(ID, PFS)) -- 2.34.1