From 6846082281272b80c3a01b913a25e75031407c0d Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Thu, 16 Jan 2014 20:22:55 +0000 Subject: [PATCH] Reduce nesting. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199418 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Object/COFFObjectFile.cpp | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/lib/Object/COFFObjectFile.cpp b/lib/Object/COFFObjectFile.cpp index d0ef1b3bbd3..007d28e6bdf 100644 --- a/lib/Object/COFFObjectFile.cpp +++ b/lib/Object/COFFObjectFile.cpp @@ -145,21 +145,19 @@ error_code COFFObjectFile::getSymbolType(DataRefImpl Ref, if (Symb->StorageClass == COFF::IMAGE_SYM_CLASS_EXTERNAL && Symb->SectionNumber == COFF::IMAGE_SYM_UNDEFINED) { Result = SymbolRef::ST_Unknown; + } else if (Symb->getComplexType() == COFF::IMAGE_SYM_DTYPE_FUNCTION) { + Result = SymbolRef::ST_Function; } else { - if (Symb->getComplexType() == COFF::IMAGE_SYM_DTYPE_FUNCTION) { - Result = SymbolRef::ST_Function; - } else { - uint32_t Characteristics = 0; - if (Symb->SectionNumber > 0) { - const coff_section *Section = NULL; - if (error_code EC = getSection(Symb->SectionNumber, Section)) - return EC; - Characteristics = Section->Characteristics; - } - if (Characteristics & COFF::IMAGE_SCN_MEM_READ && - ~Characteristics & COFF::IMAGE_SCN_MEM_WRITE) // Read only. - Result = SymbolRef::ST_Data; + uint32_t Characteristics = 0; + if (Symb->SectionNumber > 0) { + const coff_section *Section = NULL; + if (error_code EC = getSection(Symb->SectionNumber, Section)) + return EC; + Characteristics = Section->Characteristics; } + if (Characteristics & COFF::IMAGE_SCN_MEM_READ && + ~Characteristics & COFF::IMAGE_SCN_MEM_WRITE) // Read only. + Result = SymbolRef::ST_Data; } return object_error::success; } -- 2.34.1