From 691fcff3370b872092804b1b451b9a818103e82d Mon Sep 17 00:00:00 2001 From: Nick Lewycky Date: Wed, 19 Aug 2015 06:25:30 +0000 Subject: [PATCH] More clean up, still NFC. Remove dead variables now that the casts are gone. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@245420 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/LoopIdiomRecognize.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/Transforms/Scalar/LoopIdiomRecognize.cpp b/lib/Transforms/Scalar/LoopIdiomRecognize.cpp index dee64091e55..4ad1357ce8c 100644 --- a/lib/Transforms/Scalar/LoopIdiomRecognize.cpp +++ b/lib/Transforms/Scalar/LoopIdiomRecognize.cpp @@ -919,7 +919,7 @@ void LoopIdiomRecognize::transformLoopToPopcount(BasicBlock *PreCondBB, } // Step 2: Replace the precondition from "if (x == 0) goto loop-exit" to - // "if (NewCount == 0) loop-exit". Withtout this change, the intrinsic + // "if (NewCount == 0) loop-exit". Without this change, the intrinsic // function would be partial dead code, and downstream passes will drag // it back from the precondition block to the preheader. { @@ -938,7 +938,7 @@ void LoopIdiomRecognize::transformLoopToPopcount(BasicBlock *PreCondBB, } // Step 3: Note that the population count is exactly the trip count of the - // loop in question, which enble us to to convert the loop from noncountable + // loop in question, which enable us to to convert the loop from noncountable // loop into a countable one. The benefit is twofold: // // - If the loop only counts population, the entire loop becomes dead after @@ -966,10 +966,9 @@ void LoopIdiomRecognize::transformLoopToPopcount(BasicBlock *PreCondBB, PHINode *TcPhi = PHINode::Create(Ty, 2, "tcphi", Body->begin()); Builder.SetInsertPoint(LbCond); - Value *Opnd1 = TcPhi; - Value *Opnd2 = ConstantInt::get(Ty, 1); Instruction *TcDec = cast( - Builder.CreateSub(Opnd1, Opnd2, "tcdec", false, true)); + Builder.CreateSub(TcPhi, ConstantInt::get(Ty, 1), + "tcdec", false, true)); TcPhi->addIncoming(TripCnt, PreHead); TcPhi->addIncoming(TcDec, Body); -- 2.34.1