From 6a8002210a5266d2a3ecd72f825168f0194b82c9 Mon Sep 17 00:00:00 2001 From: Frederic Riss Date: Wed, 10 Sep 2014 16:03:14 +0000 Subject: [PATCH] Fix comments of createReplaceableForwardDecl() and createForwardDecl(). Noticed while trying to understand how the merge of forward decalred types and defintions work. Reviewers: echristo, dblaikie, aprantl Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D5291 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217514 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/IR/DIBuilder.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/IR/DIBuilder.cpp b/lib/IR/DIBuilder.cpp index c3beae9a28b..181c60f17ca 100644 --- a/lib/IR/DIBuilder.cpp +++ b/lib/IR/DIBuilder.cpp @@ -879,8 +879,7 @@ DIBasicType DIBuilder::createUnspecifiedParameter() { return DIBasicType(); } -/// createForwardDecl - Create a temporary forward-declared type that -/// can be RAUW'd if the full type is seen. +/// createForwardDecl - Create a permanent forward-declared type. DICompositeType DIBuilder::createForwardDecl(unsigned Tag, StringRef Name, DIDescriptor Scope, DIFile F, unsigned Line, unsigned RuntimeLang, @@ -914,7 +913,7 @@ DIBuilder::createForwardDecl(unsigned Tag, StringRef Name, DIDescriptor Scope, return RetTy; } -/// createForwardDecl - Create a temporary forward-declared type that +/// createReplaceableForwardDecl - Create a temporary forward-declared type that /// can be RAUW'd if the full type is seen. DICompositeType DIBuilder::createReplaceableForwardDecl( unsigned Tag, StringRef Name, DIDescriptor Scope, DIFile F, unsigned Line, @@ -942,7 +941,7 @@ DICompositeType DIBuilder::createReplaceableForwardDecl( MDNode *Node = MDNode::getTemporary(VMContext, Elts); DICompositeType RetTy(Node); assert(RetTy.isCompositeType() && - "createForwardDecl result should be a DIType"); + "createReplaceableForwardDecl result should be a DIType"); if (!UniqueIdentifier.empty()) retainType(RetTy); return RetTy; -- 2.34.1