From 6fc29015ff4dd822cc9840b5f7fa12455fe9fe08 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Mon, 12 Jan 2015 19:45:44 +0000 Subject: [PATCH] IR: Invert logic to simplify control flow, NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@225670 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/IR/Metadata.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/IR/Metadata.cpp b/lib/IR/Metadata.cpp index f78e7d2534d..859512db001 100644 --- a/lib/IR/Metadata.cpp +++ b/lib/IR/Metadata.cpp @@ -451,19 +451,16 @@ void GenericMDNode::resolve() { void GenericMDNode::resolveAfterOperandChange(Metadata *Old, Metadata *New) { assert(SubclassData32 != 0 && "Expected unresolved operands"); - // Check if the last unresolved operand has just been resolved; if so, - // resolve this as well. - if (isOperandUnresolved(Old)) { - if (!isOperandUnresolved(New)) - decrementUnresolvedOperandCount(); - } else { - // Operands shouldn't become unresolved. + // Check if an operand was resolved. + if (!isOperandUnresolved(Old)) assert(isOperandUnresolved(New) && "Operand just became unresolved"); - } + else if (!isOperandUnresolved(New)) + decrementUnresolvedOperandCount(); } void GenericMDNode::decrementUnresolvedOperandCount() { if (!--SubclassData32) + // Last unresolved operand has just been resolved. resolve(); } -- 2.34.1