From 71c8ec020dba204f96e4d680c2ea91f23e5588f3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Fri, 16 Jan 2015 15:59:29 +0000 Subject: [PATCH] bcm53xx: drop hacky patch making bcma init later MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The only reason this patch was helping was moving bcma init *after* of_serial init. It was a bit of luck because both drivers use device_initcall. It isn't really a correct way to provide early logging. Now we have earlyprintk support in bcm53xx we can drop this patch. Signed-off-by: Rafał Miłecki SVN-Revision: 43981 --- ...-bcma-register-SoC-later-as-a-module.patch | 42 ------------------- ...-bcma-register-SoC-later-as-a-module.patch | 42 ------------------- 2 files changed, 84 deletions(-) delete mode 100644 target/linux/bcm53xx/patches-3.14/901-bcma-register-SoC-later-as-a-module.patch delete mode 100644 target/linux/bcm53xx/patches-3.18/901-bcma-register-SoC-later-as-a-module.patch diff --git a/target/linux/bcm53xx/patches-3.14/901-bcma-register-SoC-later-as-a-module.patch b/target/linux/bcm53xx/patches-3.14/901-bcma-register-SoC-later-as-a-module.patch deleted file mode 100644 index f20b1cc82d..0000000000 --- a/target/linux/bcm53xx/patches-3.14/901-bcma-register-SoC-later-as-a-module.patch +++ /dev/null @@ -1,42 +0,0 @@ -From fee1501c494954f6e889563ca44aadfe4a83a643 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= -Date: Tue, 14 Oct 2014 00:05:42 +0200 -Subject: [PATCH] bcma: register SoC later (as a module) -MIME-Version: 1.0 -Content-Type: text/plain; charset=UTF-8 -Content-Transfer-Encoding: 8bit - -This is temporary workaround required for easier debugging. - -Signed-off-by: Rafał Miłecki ---- - drivers/bcma/host_soc.c | 12 ++++++++++-- - 1 file changed, 10 insertions(+), 2 deletions(-) - ---- a/drivers/bcma/host_soc.c -+++ b/drivers/bcma/host_soc.c -@@ -265,14 +265,22 @@ static struct platform_driver bcma_host_ - .probe = bcma_host_soc_probe, - .remove = bcma_host_soc_remove, - }; -+/* FIXME: Using module_platform_driver is a temp hack to get bcma SoC -+ * initialzed *after* serial console. This way we get some logs in case of hang -+ * inside bcma or related driver. We need that for debugging problems and it's -+ * also useful for development. Otherwise any hang (in flash driver, PCIe -+ * driver, USB driver, etc.) would result in not getting logs at all. -+ */ -+module_platform_driver(bcma_host_soc_driver); - - int __init bcma_host_soc_register_driver(void) - { -- return platform_driver_register(&bcma_host_soc_driver); -+ /* return platform_driver_register(&bcma_host_soc_driver); */ -+ return 0; - } - - void __exit bcma_host_soc_unregister_driver(void) - { -- platform_driver_unregister(&bcma_host_soc_driver); -+ /* platform_driver_unregister(&bcma_host_soc_driver); */ - } - #endif /* CONFIG_OF */ diff --git a/target/linux/bcm53xx/patches-3.18/901-bcma-register-SoC-later-as-a-module.patch b/target/linux/bcm53xx/patches-3.18/901-bcma-register-SoC-later-as-a-module.patch deleted file mode 100644 index f20b1cc82d..0000000000 --- a/target/linux/bcm53xx/patches-3.18/901-bcma-register-SoC-later-as-a-module.patch +++ /dev/null @@ -1,42 +0,0 @@ -From fee1501c494954f6e889563ca44aadfe4a83a643 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= -Date: Tue, 14 Oct 2014 00:05:42 +0200 -Subject: [PATCH] bcma: register SoC later (as a module) -MIME-Version: 1.0 -Content-Type: text/plain; charset=UTF-8 -Content-Transfer-Encoding: 8bit - -This is temporary workaround required for easier debugging. - -Signed-off-by: Rafał Miłecki ---- - drivers/bcma/host_soc.c | 12 ++++++++++-- - 1 file changed, 10 insertions(+), 2 deletions(-) - ---- a/drivers/bcma/host_soc.c -+++ b/drivers/bcma/host_soc.c -@@ -265,14 +265,22 @@ static struct platform_driver bcma_host_ - .probe = bcma_host_soc_probe, - .remove = bcma_host_soc_remove, - }; -+/* FIXME: Using module_platform_driver is a temp hack to get bcma SoC -+ * initialzed *after* serial console. This way we get some logs in case of hang -+ * inside bcma or related driver. We need that for debugging problems and it's -+ * also useful for development. Otherwise any hang (in flash driver, PCIe -+ * driver, USB driver, etc.) would result in not getting logs at all. -+ */ -+module_platform_driver(bcma_host_soc_driver); - - int __init bcma_host_soc_register_driver(void) - { -- return platform_driver_register(&bcma_host_soc_driver); -+ /* return platform_driver_register(&bcma_host_soc_driver); */ -+ return 0; - } - - void __exit bcma_host_soc_unregister_driver(void) - { -- platform_driver_unregister(&bcma_host_soc_driver); -+ /* platform_driver_unregister(&bcma_host_soc_driver); */ - } - #endif /* CONFIG_OF */ -- 2.34.1