From 7677673c9380437a7c1ad3b41d62dd3876630763 Mon Sep 17 00:00:00 2001 From: Louis Brandy Date: Mon, 25 Mar 2013 10:16:15 -0700 Subject: [PATCH] fix clang warnings in folly::Gen Summary: Two clang warnings. It wants user defined consturctor for static initialization, and it wants fwd-declare to agree with full decleration in regards to struct v class. Test Plan: `fbconfig --clang --platform=gcc-4.7.1-glibc-2.14.1 folly/test/` And make sure it doesn't break normal build. Reviewed By: tulloch@fb.com FB internal diff: D749857 --- folly/experimental/Gen-inl.h | 2 ++ folly/experimental/Gen.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/folly/experimental/Gen-inl.h b/folly/experimental/Gen-inl.h index b0e989c1..dd742500 100644 --- a/folly/experimental/Gen-inl.h +++ b/folly/experimental/Gen-inl.h @@ -1214,6 +1214,8 @@ class Count : public Operator { */ class Sum : public Operator { public: + Sum() : Operator() {} + template::type> diff --git a/folly/experimental/Gen.h b/folly/experimental/Gen.h index 513428dc..da64fde9 100644 --- a/folly/experimental/Gen.h +++ b/folly/experimental/Gen.h @@ -250,7 +250,7 @@ template class Append; template -class GeneratorBuilder; +struct GeneratorBuilder; template class Contains; -- 2.34.1