From 794caa1d2ccafa753fbdf23d0a50037f57635dbd Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 28 Apr 2002 16:04:26 +0000 Subject: [PATCH] The check to see if an external function was marked internal was not reachable! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@2366 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Verifier.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/VMCore/Verifier.cpp b/lib/VMCore/Verifier.cpp index 691f1182c3d..cd2aa842c31 100644 --- a/lib/VMCore/Verifier.cpp +++ b/lib/VMCore/Verifier.cpp @@ -69,6 +69,11 @@ namespace { // Anonymous namespace for class } bool doFinalization(Module *M) { + // Scan through, checking all of the external function's linkage now... + for (Module::iterator I = M->begin(), E = M->end(); I != E; ++I) + if ((*I)->isExternal() && (*I)->hasInternalLinkage()) + CheckFailed("", "Function Declaration has Internal Linkage!", (*I)); + if (Broken) { cerr << "Broken module found, compilation aborted!\n"; abort(); @@ -135,11 +140,8 @@ void Verifier::verifySymbolTable(SymbolTable *ST) { // void Verifier::visitFunction(Function *F) { if (F->isExternal()) return; - verifySymbolTable(F->getSymbolTable()); - // Check linkage of function... - Assert1(!F->isExternal() || F->hasExternalLinkage(), - "Function cannot be an 'internal' 'declare'ation!", F); + verifySymbolTable(F->getSymbolTable()); // Check function arguments... const FunctionType *FT = F->getFunctionType(); -- 2.34.1