From 7c8f000f43d6f89406e939ddc59da687ba040b78 Mon Sep 17 00:00:00 2001 From: Subodh Iyengar Date: Thu, 1 Dec 2016 06:39:24 -0800 Subject: [PATCH] Fix assertion in unit test Summary: Fix test for AsyncSSLSocket. When a timeout occurs during a handshake it's possible that invokeConnectError is called with sslState_ == CONNECTING. This just removes the assertion in this case. This doesnt affect prod code, only tests Reviewed By: yfeldblum Differential Revision: D4252677 fbshipit-source-id: 4db3a94ae28aa140546554c087bedcee7f06d201 --- folly/io/async/AsyncSSLSocket.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/folly/io/async/AsyncSSLSocket.cpp b/folly/io/async/AsyncSSLSocket.cpp index f8e6b471..242e0b26 100644 --- a/folly/io/async/AsyncSSLSocket.cpp +++ b/folly/io/async/AsyncSSLSocket.cpp @@ -1128,7 +1128,6 @@ void AsyncSSLSocket::invokeConnectErr(const AsyncSocketException& ex) { connectionTimeout_.cancelTimeout(); AsyncSocket::invokeConnectErr(ex); if (sslState_ == SSLStateEnum::STATE_CONNECTING) { - assert(tfoAttempted_); if (handshakeTimeout_.isScheduled()) { handshakeTimeout_.cancelTimeout(); } -- 2.34.1