From 87190c473c216e481e0a70475577e496b3a3449e Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Fri, 19 Mar 2010 09:28:12 +0000 Subject: [PATCH] MCAssembler: Move ApplyFixup to the TargetAsmBackend, this is a target specific not object writer specific task. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@98947 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Target/TargetAsmBackend.h | 10 ++++++++++ lib/MC/MCAssembler.cpp | 13 +------------ lib/Target/X86/X86AsmBackend.cpp | 26 ++++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 12 deletions(-) diff --git a/include/llvm/Target/TargetAsmBackend.h b/include/llvm/Target/TargetAsmBackend.h index faf91c4e3a0..cada3e4479f 100644 --- a/include/llvm/Target/TargetAsmBackend.h +++ b/include/llvm/Target/TargetAsmBackend.h @@ -10,7 +10,11 @@ #ifndef LLVM_TARGET_TARGETASMBACKEND_H #define LLVM_TARGET_TARGETASMBACKEND_H +#include "llvm/System/DataTypes.h" + namespace llvm { +class MCAsmFixup; +class MCDataFragment; class MCSection; class Target; @@ -75,6 +79,12 @@ public: virtual bool doesSectionRequireSymbols(const MCSection &Section) const { return false; } + + /// ApplyFixup - Apply the \arg Value for given \arg Fixup into the provided + /// data fragment, at the offset specified by the fixup and following the + /// fixup kind as appropriate. + virtual void ApplyFixup(const MCAsmFixup &Fixup, MCDataFragment &Fragment, + uint64_t Value) const = 0; }; } // End llvm namespace diff --git a/lib/MC/MCAssembler.cpp b/lib/MC/MCAssembler.cpp index 500f23f6909..c4c3a8a4f85 100644 --- a/lib/MC/MCAssembler.cpp +++ b/lib/MC/MCAssembler.cpp @@ -930,17 +930,6 @@ public: OS << StringTable.str(); } } - - void ApplyFixup(const MCAsmFixup &Fixup, MCDataFragment &DF, - uint64_t FixedValue) { - unsigned Size = 1 << getFixupKindLog2Size(Fixup.Kind); - - // FIXME: Endianness assumption. - assert(Fixup.Offset + Size <= DF.getContents().size() && - "Invalid fixup offset!"); - for (unsigned i = 0; i != Size; ++i) - DF.getContents()[Fixup.Offset + i] = uint8_t(FixedValue >> (i * 8)); - } }; /* *** */ @@ -1475,7 +1464,7 @@ void MCAssembler::Finish() { MOW.RecordRelocation(*this, *DF, Fixup, Target, FixedValue); } - MOW.ApplyFixup(Fixup, *DF, FixedValue); + getBackend().ApplyFixup(Fixup, *DF, FixedValue); } } } diff --git a/lib/Target/X86/X86AsmBackend.cpp b/lib/Target/X86/X86AsmBackend.cpp index d7a9e1a9653..fec563817e6 100644 --- a/lib/Target/X86/X86AsmBackend.cpp +++ b/lib/Target/X86/X86AsmBackend.cpp @@ -9,6 +9,8 @@ #include "llvm/Target/TargetAsmBackend.h" #include "X86.h" +#include "X86FixupKinds.h" +#include "llvm/MC/MCAssembler.h" #include "llvm/MC/MCSectionMachO.h" #include "llvm/Target/TargetRegistry.h" #include "llvm/Target/TargetAsmBackend.h" @@ -16,10 +18,34 @@ using namespace llvm; namespace { +static unsigned getFixupKindLog2Size(unsigned Kind) { + switch (Kind) { + default: assert(0 && "invalid fixup kind!"); + case X86::reloc_pcrel_1byte: + case FK_Data_1: return 0; + case FK_Data_2: return 1; + case X86::reloc_pcrel_4byte: + case X86::reloc_riprel_4byte: + case X86::reloc_riprel_4byte_movq_load: + case FK_Data_4: return 2; + case FK_Data_8: return 3; + } +} + class X86AsmBackend : public TargetAsmBackend { public: X86AsmBackend(const Target &T) : TargetAsmBackend(T) {} + + void ApplyFixup(const MCAsmFixup &Fixup, MCDataFragment &DF, + uint64_t Value) const { + unsigned Size = 1 << getFixupKindLog2Size(Fixup.Kind); + + assert(Fixup.Offset + Size <= DF.getContents().size() && + "Invalid fixup offset!"); + for (unsigned i = 0; i != Size; ++i) + DF.getContents()[Fixup.Offset + i] = uint8_t(Value >> (i * 8)); + } }; class DarwinX86AsmBackend : public X86AsmBackend { -- 2.34.1