From 877e7ce051aa0b29e68be9a5633cc8e17e2ec332 Mon Sep 17 00:00:00 2001 From: Reid Spencer Date: Mon, 8 Jan 2007 19:41:01 +0000 Subject: [PATCH] Parameter attributes are part of a FunctionType and deserve to be factored into comparisons of two FunctionTypes. Make it so. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@33020 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Type.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/VMCore/Type.cpp b/lib/VMCore/Type.cpp index 25da1e3a851..258aed03934 100644 --- a/lib/VMCore/Type.cpp +++ b/lib/VMCore/Type.cpp @@ -607,11 +607,16 @@ static bool TypesEqual(const Type *Ty, const Type *Ty2, const FunctionType *FTy2 = cast(Ty2); if (FTy->isVarArg() != FTy2->isVarArg() || FTy->getNumParams() != FTy2->getNumParams() || + FTy->getNumAttrs() != FTy2->getNumAttrs() || + FTy->getParamAttrs(0) != FTy2->getParamAttrs(0) || !TypesEqual(FTy->getReturnType(), FTy2->getReturnType(), EqTypes)) return false; - for (unsigned i = 0, e = FTy2->getNumParams(); i != e; ++i) + for (unsigned i = 0, e = FTy2->getNumParams(); i != e; ++i) { + if (FTy->getParamAttrs(i+1) != FTy->getParamAttrs(i+1)) + return false; if (!TypesEqual(FTy->getParamType(i), FTy2->getParamType(i), EqTypes)) return false; + } return true; } else { assert(0 && "Unknown derived type!"); -- 2.34.1