From 89353dca07263ccb9d78e618584f94daa25c371a Mon Sep 17 00:00:00 2001 From: Adam Simpkins Date: Wed, 29 Nov 2017 17:35:17 -0800 Subject: [PATCH] logging: remove comment about LogLevel::ERROR Summary: The logging code used to support a LogLevel::ERROR value on non-Windows platforms. I removed it in D5288600 to make all platforms consistent, but I forgot to remove this comment describing it. Reviewed By: bolinfest Differential Revision: D6341244 fbshipit-source-id: 054427d342066f354c859b12611b907dc2d4fa35 --- folly/experimental/logging/LogLevel.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/folly/experimental/logging/LogLevel.h b/folly/experimental/logging/LogLevel.h index c0dc40d0..605da062 100644 --- a/folly/experimental/logging/LogLevel.h +++ b/folly/experimental/logging/LogLevel.h @@ -56,11 +56,8 @@ enum class LogLevel : uint32_t { WARN = 3000, WARNING = 3000, - // Unfortunately Windows headers #define ERROR - // On Windows platforms we avoid defining ERROR. However we make it - // available on other platforms, to make it easier to convert code from - // other log libraries that also use ERROR as their log level name (e.g., - // glog). + // Unfortunately Windows headers #define ERROR, so we cannot use + // it as an enum value name. We only provide ERR instead. ERR = 4000, CRITICAL = 5000, -- 2.34.1