From 8c8b9ee8c8646aa1a79c782d4da9abdf3eb4eefe Mon Sep 17 00:00:00 2001 From: Argyrios Kyrtzidis Date: Sun, 15 Aug 2010 10:27:23 +0000 Subject: [PATCH] Revert r111082. No warnings for this common pattern. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@111102 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/InstCount.cpp | 2 +- lib/Bitcode/Reader/BitcodeReader.cpp | 4 ++-- lib/Linker/LinkModules.cpp | 4 ++-- lib/Target/X86/X86MCCodeEmitter.cpp | 5 ++--- lib/VMCore/Verifier.cpp | 4 ++-- .../unittest/googletest/include/gtest/internal/gtest-port.h | 4 ++-- 6 files changed, 11 insertions(+), 12 deletions(-) diff --git a/lib/Analysis/InstCount.cpp b/lib/Analysis/InstCount.cpp index 32febd6ef05..dcbcac005a2 100644 --- a/lib/Analysis/InstCount.cpp +++ b/lib/Analysis/InstCount.cpp @@ -45,7 +45,7 @@ namespace { #include "llvm/Instruction.def" - void visitInstruction(Instruction &I) ATTRIBUTE_UNUSED { + void visitInstruction(Instruction &I) { errs() << "Instruction Count does not know about " << I; llvm_unreachable(0); } diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index be2c1ce9862..8f999a68758 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -135,8 +135,8 @@ namespace { /// @brief A class for maintaining the slot number definition /// as a placeholder for the actual definition for forward constants defs. class ConstantPlaceHolder : public ConstantExpr { - ConstantPlaceHolder() ATTRIBUTE_UNUSED; // DO NOT IMPLEMENT - void operator=(const ConstantPlaceHolder &) ATTRIBUTE_UNUSED;//NOT IMPLEMENT + ConstantPlaceHolder(); // DO NOT IMPLEMENT + void operator=(const ConstantPlaceHolder &); // DO NOT IMPLEMENT public: // allocate space for exactly one operand void *operator new(size_t s) { diff --git a/lib/Linker/LinkModules.cpp b/lib/Linker/LinkModules.cpp index 4984d934bb3..4891631bc9c 100644 --- a/lib/Linker/LinkModules.cpp +++ b/lib/Linker/LinkModules.cpp @@ -78,8 +78,8 @@ class LinkerTypeMap : public AbstractTypeUser { typedef DenseMap TheMapTy; TheMapTy TheMap; - LinkerTypeMap(const LinkerTypeMap&) ATTRIBUTE_UNUSED; // DO NOT IMPLEMENT - void operator=(const LinkerTypeMap&) ATTRIBUTE_UNUSED; // DO NOT IMPLEMENT + LinkerTypeMap(const LinkerTypeMap&); // DO NOT IMPLEMENT + void operator=(const LinkerTypeMap&); // DO NOT IMPLEMENT public: LinkerTypeMap() {} ~LinkerTypeMap() { diff --git a/lib/Target/X86/X86MCCodeEmitter.cpp b/lib/Target/X86/X86MCCodeEmitter.cpp index 063de1998ee..b39fce1f79c 100644 --- a/lib/Target/X86/X86MCCodeEmitter.cpp +++ b/lib/Target/X86/X86MCCodeEmitter.cpp @@ -19,13 +19,12 @@ #include "llvm/MC/MCExpr.h" #include "llvm/MC/MCInst.h" #include "llvm/Support/raw_ostream.h" -#include "llvm/Support/Compiler.h" using namespace llvm; namespace { class X86MCCodeEmitter : public MCCodeEmitter { - X86MCCodeEmitter(const X86MCCodeEmitter &) ATTRIBUTE_UNUSED; // DONT IMPLEMENT - void operator=(const X86MCCodeEmitter &) ATTRIBUTE_UNUSED; // DO NOT IMPLEMENT + X86MCCodeEmitter(const X86MCCodeEmitter &); // DO NOT IMPLEMENT + void operator=(const X86MCCodeEmitter &); // DO NOT IMPLEMENT const TargetMachine &TM; const TargetInstrInfo &TII; MCContext &Ctx; diff --git a/lib/VMCore/Verifier.cpp b/lib/VMCore/Verifier.cpp index 3aaf8cbe810..8ff15514243 100644 --- a/lib/VMCore/Verifier.cpp +++ b/lib/VMCore/Verifier.cpp @@ -151,8 +151,8 @@ namespace { SmallSetVector Types; // Disallow copying. - TypeSet(const TypeSet &) ATTRIBUTE_UNUSED; - TypeSet &operator=(const TypeSet &) ATTRIBUTE_UNUSED; + TypeSet(const TypeSet &); + TypeSet &operator=(const TypeSet &); }; struct Verifier : public FunctionPass, public InstVisitor { diff --git a/utils/unittest/googletest/include/gtest/internal/gtest-port.h b/utils/unittest/googletest/include/gtest/internal/gtest-port.h index fb936199f68..9683271e48f 100644 --- a/utils/unittest/googletest/include/gtest/internal/gtest-port.h +++ b/utils/unittest/googletest/include/gtest/internal/gtest-port.h @@ -556,12 +556,12 @@ // A macro to disallow operator= // This should be used in the private: declarations for a class. #define GTEST_DISALLOW_ASSIGN_(type)\ - void operator=(type const &) GTEST_ATTRIBUTE_UNUSED_ + void operator=(type const &) // A macro to disallow copy constructor and operator= // This should be used in the private: declarations for a class. #define GTEST_DISALLOW_COPY_AND_ASSIGN_(type)\ - type(type const &) GTEST_ATTRIBUTE_UNUSED_;\ + type(type const &);\ GTEST_DISALLOW_ASSIGN_(type) // Tell the compiler to warn about unused return values for functions declared -- 2.34.1