From 8cae10aa7399b37ef15a85f9afbf485cf57a5135 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 6 Jan 2015 20:54:29 -0800 Subject: [PATCH] folly/test/ForeachTest.cpp: avoid -Wsign-compare error Summary: * folly/test/ForeachTest.cpp: Change a "1" to "1U", so it matches the signedness of the size_t upper bound. Otherwise, gcc-4.9 fails with e.g., folly/Foreach.h:194:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Test Plan: Run this and note there are fewer errors than before: fbconfig --platform-all=gcc-4.9-glibc-2.20 -r folly && fbmake dbgo Reviewed By: andrei.alexandrescu@fb.com Subscribers: folly-diffs@ FB internal diff: D1770603 Tasks: 5941250 Signature: t1:1770603:1420679246:56ef62ac7fa4413a4ad6310c3381a12bdc59e64c --- folly/test/ForeachTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/test/ForeachTest.cpp b/folly/test/ForeachTest.cpp index bff6b502..aa765a8b 100644 --- a/folly/test/ForeachTest.cpp +++ b/folly/test/ForeachTest.cpp @@ -266,7 +266,7 @@ BENCHMARK(ForEachDescendingManual, iters) { BENCHMARK(ForEachRangeR, iters) { int sum = 1; - FOR_EACH_RANGE_R (i, 1, iters) { + FOR_EACH_RANGE_R (i, 1U, iters) { sum *= i; } doNotOptimizeAway(sum); -- 2.34.1