From 8dcc58e6b44fbaab39a24b1f75e67f05275084dc Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Tue, 26 Jan 2010 15:56:18 +0000 Subject: [PATCH] Fix a typo that several people pointed out. Also, address the case of wrapping that Duncan pointed out. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94547 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/ConstantRange.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Support/ConstantRange.cpp b/lib/Support/ConstantRange.cpp index e9ddffc06ba..2746f7aaaa5 100644 --- a/lib/Support/ConstantRange.cpp +++ b/lib/Support/ConstantRange.cpp @@ -540,8 +540,10 @@ ConstantRange::add(const ConstantRange &Other) const { ConstantRange ConstantRange::multiply(const ConstantRange &Other) const { - // TODO: If either operand is a single element, round the result min anx - // max value to the appropriate multiple of that element. + // TODO: If either operand is a single element and the multiply is known to + // be non-wrapping, round the result min and max value to the appropriate + // multiple of that element. If wrapping is possible, at least adjust the + // range according to the greatest power-of-two factor of the single element. if (isEmptySet() || Other.isEmptySet()) return ConstantRange(getBitWidth(), /*isFullSet=*/false); -- 2.34.1